Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1741823002: Get SkiaServe Request started off with a little privacy (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@skiaserve-7-wireup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Get SkiaServe Request started off with a little privacy This CL moves the surface stuff into the request object so it can maintain its internal state consistently BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1741823002 Committed: https://skia.googlesource.com/skia/+/ee5348b069d53e5d843b2cebbac728ca7868d9fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -45 lines) Patch
M tools/skiaserve/Request.h View 3 chunks +11 lines, -7 lines 0 comments Download
M tools/skiaserve/Request.cpp View 4 chunks +48 lines, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/skiaserve/urlhandlers/EnableGPUHandler.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M tools/skiaserve/urlhandlers/InfoHandler.cpp View 2 chunks +3 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
joshualitt
A minor CL which just moves some logic into Request so we can start to ...
4 years, 9 months ago (2016-02-26 16:03:39 UTC) #3
ethannicholas
On 2016/02/26 16:03:39, joshualitt wrote: > A minor CL which just moves some logic into ...
4 years, 9 months ago (2016-02-26 16:05:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741823002/1
4 years, 9 months ago (2016-02-26 16:24:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 16:36:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee5348b069d53e5d843b2cebbac728ca7868d9fa

Powered by Google App Engine
This is Rietveld 408576698