Add batchlist managment to GrAuditTrail

Add batchlist managment to GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724243004

Committed: https://skia.googlesource.com/skia/+/18d6b75829ac5d90050ca4da4f99292c14ff06f0

[joshua.litt, 2016-02-24 21:14:58]

Description was changed from

==========
Add batchlist managment to GrAuditTrail

BUG=skia:
==========

to

==========
Add batchlist managment to GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-24 22:03:14]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, joshualitt@google.com

[joshualitt, 2016-02-24 22:03:15]

this patch isn't quite done because I have to figure out how to manage the
lifetime of the eventpool.  Still, I wanted to get it in front of you ASAP in
case you had different ideas about how this should work.

In a nutshell, we now build up a side car array of batches called a batchList. 
The idea being we can return this quite flat list of batches as JSON, and then
draw the bounds for all of the batches in the batch and the whole batch itself.

[joshualitt, 2016-02-25 14:54:22]

On 2016/02/24 22:03:15, joshualitt wrote:
> this patch isn't quite done because I have to figure out how to manage the
> lifetime of the eventpool.  Still, I wanted to get it in front of you ASAP in
> case you had different ideas about how this should work.
> 
> In a nutshell, we now build up a side car array of batches called a batchList.

> The idea being we can return this quite flat list of batches as JSON, and then
> draw the bounds for all of the batches in the batch and the whole batch
itself.

Okay, I created an Auto class to manage the lifetime of the batchlist, ptal

[joshualitt, 2016-02-26 15:40:44]

On 2016/02/25 14:54:22, joshualitt wrote:
> On 2016/02/24 22:03:15, joshualitt wrote:
> > this patch isn't quite done because I have to figure out how to manage the
> > lifetime of the eventpool.  Still, I wanted to get it in front of you ASAP
in
> > case you had different ideas about how this should work.
> > 
> > In a nutshell, we now build up a side car array of batches called a
batchList.
> 
> > The idea being we can return this quite flat list of batches as JSON, and
then
> > draw the bounds for all of the batches in the batch and the whole batch
> itself.
> 
> Okay, I created an Auto class to manage the lifetime of the batchlist, ptal

pinging this, I admit this CL is quite far from perfect, but I already have some
ideas for down the road trying to clean it up a bit, and in a further CL I have
the bounds drawing in SkiaServe.  I think things will become much clearer when
we try to cross reference between Skia draw ops and batches, but I think this CL
gets us moving in the right direction.

[ethannicholas, 2016-02-26 15:41:54]

On 2016/02/26 15:40:44, joshualitt wrote:
> On 2016/02/25 14:54:22, joshualitt wrote:
> > On 2016/02/24 22:03:15, joshualitt wrote:
> > > this patch isn't quite done because I have to figure out how to manage the
> > > lifetime of the eventpool.  Still, I wanted to get it in front of you ASAP
> in
> > > case you had different ideas about how this should work.
> > > 
> > > In a nutshell, we now build up a side car array of batches called a
> batchList.
> > 
> > > The idea being we can return this quite flat list of batches as JSON, and
> then
> > > draw the bounds for all of the batches in the batch and the whole batch
> > itself.
> > 
> > Okay, I created an Auto class to manage the lifetime of the batchlist, ptal
> 
> pinging this, I admit this CL is quite far from perfect, but I already have
some
> ideas for down the road trying to clean it up a bit, and in a further CL I
have
> the bounds drawing in SkiaServe.  I think things will become much clearer when
> we try to cross reference between Skia draw ops and batches, but I think this
CL
> gets us moving in the right direction.

lgtm

[joshualitt, 2016-02-26 15:46:19]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-02-26 15:46:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1724243004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1724243004/80001

[commit-bot: I haz the power, 2016-02-26 16:07:52]

Description was changed from

==========
Add batchlist managment to GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add batchlist managment to GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/18d6b75829ac5d90050ca4da4f99292c14ff06f0
==========

[commit-bot: I haz the power, 2016-02-26 16:07:52]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/18d6b75829ac5d90050ca4da4f99292c14ff06f0