Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: src/assembler.h

Issue 1737043002: [Interpreter] Log source positions for bytecode arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_cpu_profiler
Patch Set: TickLinesBaseline now works with more source positions Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/assembler-arm64.h ('k') | src/assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index 7bd9ee65f2c98c7622e34df862d4d72f5d9bee95..2224b9fb12e2363e681bf3c0b711a717ad226929 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -38,6 +38,7 @@
#include "src/allocation.h"
#include "src/builtins.h"
#include "src/isolate.h"
+#include "src/log.h"
#include "src/runtime/runtime.h"
namespace v8 {
@@ -1085,23 +1086,11 @@ struct PositionState {
int written_statement_position;
};
-
-class PositionsRecorder BASE_EMBEDDED {
+class AssemblerPositionsRecorder : public PositionsRecorder {
public:
- explicit PositionsRecorder(Assembler* assembler)
- : assembler_(assembler) {
- jit_handler_data_ = NULL;
- }
-
- void AttachJITHandlerData(void* user_data) {
- jit_handler_data_ = user_data;
- }
+ explicit AssemblerPositionsRecorder(Assembler* assembler)
+ : assembler_(assembler) {}
- void* DetachJITHandlerData() {
- void* old_data = jit_handler_data_;
- jit_handler_data_ = NULL;
- return old_data;
- }
// Set current position to pos.
void RecordPosition(int pos);
@@ -1121,11 +1110,7 @@ class PositionsRecorder BASE_EMBEDDED {
Assembler* assembler_;
PositionState state_;
- // Currently jit_handler_data_ is used to store JITHandler-specific data
- // over the lifetime of a PositionsRecorder
- void* jit_handler_data_;
-
- DISALLOW_COPY_AND_ASSIGN(PositionsRecorder);
+ DISALLOW_COPY_AND_ASSIGN(AssemblerPositionsRecorder);
};
« no previous file with comments | « src/arm64/assembler-arm64.h ('k') | src/assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698