Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1736283003: Don't expand <symbol> elements in <use> that are not targets (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-use-symbol-siblings-in-shadow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't expand <symbol> elements in <use> that are not targets When a <use> was referencing a subtree which contained a <symbol> element, the <symbol> would get replaced by the "replace <symbol>" part of the <use> expansion. This would result in content being rendered that should not (since only <symbol>s that are directly referenced by <use> should render.) Instead of blindly expanding <symbol> elements, replace them directly when producing the instance clone. Replace the old faulty test svg/custom/use-on-g-containing-symbol.svg with a new test. Test from: https://bugs.webkit.org/show_bug.cgi?id=154576 BUG=589682 Committed: https://crrev.com/908f01e663ef0073b3ef667258432e78add83a7b Cr-Commit-Position: refs/heads/master@{#379532}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Less removals #

Patch Set 3 : Drop additional fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -119 lines) Patch
D third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-symbol-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-symbol-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-symbol-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-symbol-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-symbol-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-symbol.html View 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-symbol.svg View 1 chunk +0 lines, -19 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-symbol-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 2 5 chunks +33 lines, -49 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
fs
4 years, 9 months ago (2016-02-26 19:15:57 UTC) #5
pdr.
Sorry about taking a while to get to this review. I wonder if it would ...
4 years, 9 months ago (2016-02-29 23:45:40 UTC) #6
fs
On 2016/02/29 at 23:45:40, pdr wrote: > Sorry about taking a while to get to ...
4 years, 9 months ago (2016-03-01 09:50:07 UTC) #7
fs
On 2016/03/01 at 09:50:07, fs wrote: > On 2016/02/29 at 23:45:40, pdr wrote: > > ...
4 years, 9 months ago (2016-03-04 20:12:39 UTC) #10
pdr.
On 2016/03/04 at 20:12:39, fs wrote: > On 2016/03/01 at 09:50:07, fs wrote: > > ...
4 years, 9 months ago (2016-03-04 22:15:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736283003/40001
4 years, 9 months ago (2016-03-07 08:40:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 10:22:07 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 10:23:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/908f01e663ef0073b3ef667258432e78add83a7b
Cr-Commit-Position: refs/heads/master@{#379532}

Powered by Google App Engine
This is Rietveld 408576698