third_party/WebKit/Source/core/svg/SVGUseElement.h - Issue 1736283003: Don't expand <symbol> elements in <use> that are not targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 1736283003: Don't expand <symbol> elements in <use> that are not targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-use-symbol-siblings-in-shadow

Patch Set: Drop additional fix. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-symbol-expected.html ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGUseElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.h b/third_party/WebKit/Source/core/svg/SVGUseElement.h

index 476bc03b0ccf3dca9104fe34026e73afb7fce8fd..e5ea54869217fc2ea82d5ef4554a8001e4672e7d 100644

--- a/third_party/WebKit/Source/core/svg/SVGUseElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.h

@@ -95,7 +95,6 @@ private:

void clearShadowTree();

bool hasCycleUseReferencing(const SVGUseElement&, const ContainerNode& targetInstance, SVGElement*& newTarget) const;

bool expandUseElementsInShadowTree();

- void expandSymbolElementsInShadowTree();

void cloneNonMarkupEventListeners();

void addReferencesToFirstDegreeNestedUseElements(SVGElement& target);