third_party/WebKit/Source/core/svg/SVGUseElement.h - Issue 1736283003: Don't expand <symbol> elements in <use> that are not targets

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 1736283003: Don't expand <symbol> elements in <use> that are not targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-use-symbol-siblings-in-shadow

Patch Set: Drop additional fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/use-on-g-containing-symbol-expected.html ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>	2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>

3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88	88

89 bool selfHasRelativeLengths() const override;	89 bool selfHasRelativeLengths() const override;

90	90

91 // Instance tree handling	91 // Instance tree handling

92 void buildShadowAndInstanceTree(SVGElement& target);	92 void buildShadowAndInstanceTree(SVGElement& target);

93 void clearInstanceRoot();	93 void clearInstanceRoot();

94 PassRefPtrWillBeRawPtr<Element> createInstanceTree(SVGElement& targetRoot) c onst;	94 PassRefPtrWillBeRawPtr<Element> createInstanceTree(SVGElement& targetRoot) c onst;

95 void clearShadowTree();	95 void clearShadowTree();

96 bool hasCycleUseReferencing(const SVGUseElement&, const ContainerNode& targe tInstance, SVGElement*& newTarget) const;	96 bool hasCycleUseReferencing(const SVGUseElement&, const ContainerNode& targe tInstance, SVGElement*& newTarget) const;

97 bool expandUseElementsInShadowTree();	97 bool expandUseElementsInShadowTree();

98 void expandSymbolElementsInShadowTree();

99 void cloneNonMarkupEventListeners();	98 void cloneNonMarkupEventListeners();

100 void addReferencesToFirstDegreeNestedUseElements(SVGElement& target);	99 void addReferencesToFirstDegreeNestedUseElements(SVGElement& target);

101	100

102 void invalidateDependentShadowTrees();	101 void invalidateDependentShadowTrees();

103	102

104 bool resourceIsStillLoading() const;	103 bool resourceIsStillLoading() const;

105 bool resourceIsValid() const;	104 bool resourceIsValid() const;

106 Document* externalDocument() const;	105 Document* externalDocument() const;

107 bool instanceTreeIsLoading() const;	106 bool instanceTreeIsLoading() const;

108 void notifyFinished(Resource*) override;	107 void notifyFinished(Resource*) override;

109 String debugName() const override { return "SVGUseElement"; }	108 String debugName() const override { return "SVGUseElement"; }

110 void setDocumentResource(PassRefPtrWillBeRawPtr<DocumentResource>);	109 void setDocumentResource(PassRefPtrWillBeRawPtr<DocumentResource>);

111	110

112 RefPtrWillBeMember<SVGAnimatedLength> m_x;	111 RefPtrWillBeMember<SVGAnimatedLength> m_x;

113 RefPtrWillBeMember<SVGAnimatedLength> m_y;	112 RefPtrWillBeMember<SVGAnimatedLength> m_y;

114 RefPtrWillBeMember<SVGAnimatedLength> m_width;	113 RefPtrWillBeMember<SVGAnimatedLength> m_width;

115 RefPtrWillBeMember<SVGAnimatedLength> m_height;	114 RefPtrWillBeMember<SVGAnimatedLength> m_height;

116	115

117 bool m_haveFiredLoadEvent;	116 bool m_haveFiredLoadEvent;

118 bool m_needsShadowTreeRecreation;	117 bool m_needsShadowTreeRecreation;

119 RefPtrWillBeMember<SVGElement> m_targetElementInstance;	118 RefPtrWillBeMember<SVGElement> m_targetElementInstance;

120 RefPtrWillBeMember<DocumentResource> m_resource;	119 RefPtrWillBeMember<DocumentResource> m_resource;

121 };	120 };

122	121

123 } // namespace blink	122 } // namespace blink

124	123

125 #endif // SVGUseElement_h	124 #endif // SVGUseElement_h

OLD	NEW