Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java

Issue 1736203002: [Contextual Search] Add metrics for Resolve and View timing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
index 50796ab6cae0f71c25fc96289dae8ded541f836a..fa02a3a0ff3f191df03eed37dc17614f98e54e25 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
@@ -383,6 +383,14 @@ public class ContextualSearchPanel extends OverlayPanel {
}
/**
+ * Notifies the panel that the Search Results are now viewable in the panel.
+ * @param didResolve Whether the search required Search Term Resolution.
+ */
+ public void onSearchResultsViewable(boolean didResolve) {
pedro (no code reviews) 2016/02/26 22:30:09 Does this mean the results were viewed, or that th
Donn Denman 2016/02/27 00:18:39 Humm, onSearchResultsPrefetched seems confusing to
pedro (no code reviews) 2016/02/27 00:39:04 Good point. onPrefetchedSearchNavigated() seems go
+ mPanelMetrics.onSearchResultsViewable(didResolve);
+ }
+
+ /**
* Maximizes the Contextual Search Panel, then promotes it to a regular Tab.
* @param reason The {@code StateChangeReason} behind the maximization and promotion to tab.
*/
@@ -470,7 +478,8 @@ public class ContextualSearchPanel extends OverlayPanel {
* Handles showing the resolved search term in the SearchBar.
* @param searchTerm The string that represents the search term.
*/
- public void onSearchTermResolutionResponse(String searchTerm) {
+ public void onSearchTermResolved(String searchTerm) {
+ mPanelMetrics.onSearchTermResolved();
getSearchBarControl().setSearchTerm(searchTerm);
animateSearchTermResolution();
}

Powered by Google App Engine
This is Rietveld 408576698