Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3376)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index da10776145b10134468bb4c775a326e095870822..5ae8bf8649509945d2afa8a421f0ffd6b58583b3 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -2099,7 +2099,12 @@ class MockWebContentsObserver : public WebContentsObserver {
got_user_gesture_(false) {
}
- void DidGetUserGesture() override { got_user_gesture_ = true; }
+ void DidGetUserInteraction(const blink::WebInputEvent::Type type) override {
+ // We expect the only interaction here to be a browser-initiated navigation,
+ // which is sent with the Undefined event type.
+ EXPECT_EQ(blink::WebInputEvent::Undefined, type);
+ got_user_gesture_ = true;
+ }
bool got_user_gesture() const {
return got_user_gesture_;
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698