Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_delegate.h
diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h
index 4c0fea95f6e5c73204fab031a5bdd1225a292eef..e562f2908270c349b2a0521ecff68f1c9f66a35b 100644
--- a/content/browser/renderer_host/render_widget_host_delegate.h
+++ b/content/browser/renderer_host/render_widget_host_delegate.h
@@ -79,21 +79,18 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {
virtual bool HandleWheelEvent(const blink::WebMouseWheelEvent& event);
// Notification the user has performed a direct interaction (mouse down, mouse
- // wheel, raw key down, or gesture tap) while focus was on the page. Informs
- // the delegate that a user is interacting with a site. Only the first mouse
- // wheel event during a scroll will trigger this method.
- virtual void OnUserInteraction(const blink::WebInputEvent::Type type) {}
+ // wheel, raw key down, gesture tap, or browser-initiated navigation) while
+ // focus was on the page. Informs the delegate that a user is interacting with
+ // a site. Only the first mouse wheel event during a scroll will trigger this
+ // method.
+ virtual void OnUserInteraction(RenderWidgetHostImpl* render_widget_host,
+ const blink::WebInputEvent::Type type) {}
// Callback to give the browser a chance to handle the specified gesture
// event before sending it to the renderer.
// Returns true if the |event| was handled.
virtual bool PreHandleGestureEvent(const blink::WebGestureEvent& event);
- // Notification the user has made a gesture while focus was on the
- // page. This is used to avoid uninitiated user downloads (aka carpet
- // bombing), see DownloadRequestLimiter for details.
- virtual void OnUserGesture(RenderWidgetHostImpl* render_widget_host) {}
-
// Notifies that screen rects were sent to renderer process.
virtual void DidSendScreenRects(RenderWidgetHostImpl* rwh) {}
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698