chrome/browser/engagement/site_engagement_helper.cc - Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index 69d8ee93b23228092a1ab7234ba325c4f31ce054..089e47c03bd15457a5e85dbf5832958207e9e4ef 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -105,6 +105,9 @@ void SiteEngagementHelper::InputTracker::DidGetUserInteraction(

case blink::WebInputEvent::MouseWheel:

helper()->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_WHEEL);

break;

+ case blink::WebInputEvent::Undefined:

+ // Explicitly ignore browser-initiated navigation input.

+ break;

default:

NOTREACHED();

}

« no previous file with comments | « no previous file | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »