[turbofan] Adds an Allocate macro to the CodeStubAssembler.

[turbofan] Adds an Allocate macro to the CodeStubAssembler.

The macro is currently used by AllocateHeapNumberStub and AllocateMutableHeapNumberStub, which are now turbofan code stubs.
It can be used to allocate objects in the new or old space, optionally with double alignment.

BUG=588692
LOG=y

Committed: https://crrev.com/820e27f98d2beae88a612a32bbeff26a6c19db97
Cr-Commit-Position: refs/heads/master@{#34424}

[epertoso, 2016-02-25 11:44:20]

Patchset #1 (id:1) has been deleted

[epertoso, 2016-02-25 11:45:39]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[epertoso, 2016-02-25 12:56:47]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 12:56:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735803003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735803003/20001

[Benedikt Meurer, 2016-02-25 13:00:41]

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc#newco...
src/code-stubs.cc:482: assembler->IntPtrAdd(
Please don't nest these computations, add separate named temporaries as in the
StringLengthStub please.

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc#newco...
src/code-stubs.cc:493: assembler->StoreNoWriteBarrier(
Same here.

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:71: enum AllocationFlags : uint8_t {
Can you move this into the CodeStubAssembler?

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:73: kTagObject = 1,
Don't add kTagObject here. This is terrible in the MacroAssembler (easy to mess
up). Allocate* will always produce tagged pointers.

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:78: inline AllocationFlags
operator|(AllocationFlags lhs, AllocationFlags rhs) {
Use base::Flags and DEFINE_OPERATORS_FOR_FLAGS here.

[epertoso, 2016-02-25 13:26:54]

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc#newco...
src/code-stubs.cc:482: assembler->IntPtrAdd(
On 2016/02/25 at 13:00:40, Benedikt Meurer wrote:
> Please don't nest these computations, add separate named temporaries as in the
StringLengthStub please.

Done.

https://codereview.chromium.org/1735803003/diff/20001/src/code-stubs.cc#newco...
src/code-stubs.cc:493: assembler->StoreNoWriteBarrier(
On 2016/02/25 at 13:00:40, Benedikt Meurer wrote:
> Same here.

Done.

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:71: enum AllocationFlags : uint8_t {
On 2016/02/25 at 13:00:40, Benedikt Meurer wrote:
> Can you move this into the CodeStubAssembler?

Done.

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:73: kTagObject = 1,
On 2016/02/25 at 13:00:41, Benedikt Meurer wrote:
> Don't add kTagObject here. This is terrible in the MacroAssembler (easy to
mess up). Allocate* will always produce tagged pointers.

OK.

https://codereview.chromium.org/1735803003/diff/20001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:78: inline AllocationFlags
operator|(AllocationFlags lhs, AllocationFlags rhs) {
On 2016/02/25 at 13:00:40, Benedikt Meurer wrote:
> Use base::Flags and DEFINE_OPERATORS_FOR_FLAGS here.

Done.

[Benedikt Meurer, 2016-02-25 13:34:39]

LGTM.

[epertoso, 2016-02-25 13:38:56]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-02-25 13:38:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1735803003/#ps60001
(title: "Fixed CodeStubAssembler::Allocate's comment.")

[commit-bot: I haz the power, 2016-02-25 13:39:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735803003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735803003/60001

[commit-bot: I haz the power, 2016-02-25 14:08:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 14:08:34]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[epertoso, 2016-03-02 11:49:26]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-03-02 11:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1735803003/#ps80001
(title: "Update.")

[commit-bot: I haz the power, 2016-03-02 11:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735803003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735803003/80001

[commit-bot: I haz the power, 2016-03-02 12:16:20]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-02 12:16:57]

Description was changed from

==========
[turbofan] Adds an Allocate macro to the CodeStubAssembler.

The macro is currently used by AllocateHeapNumberStub and
AllocateMutableHeapNumberStub, which are now turbofan code stubs.
It can be used to allocate objects in the new or old space, optionally with
double alignment.

BUG=588692
LOG=y
==========

to

==========
[turbofan] Adds an Allocate macro to the CodeStubAssembler.

The macro is currently used by AllocateHeapNumberStub and
AllocateMutableHeapNumberStub, which are now turbofan code stubs.
It can be used to allocate objects in the new or old space, optionally with
double alignment.

BUG=588692
LOG=y

Committed: https://crrev.com/820e27f98d2beae88a612a32bbeff26a6c19db97
Cr-Commit-Position: refs/heads/master@{#34424}
==========

[commit-bot: I haz the power, 2016-03-02 12:16:58]

Patchset 4 (id:??) landed as
https://crrev.com/820e27f98d2beae88a612a32bbeff26a6c19db97
Cr-Commit-Position: refs/heads/master@{#34424}