[turbofan] Adds an Allocate macro to the CodeStubAssembler.

src/compiler/code-stub-assembler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 #define V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 
 #include <map>
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
@@ skipping 50 matching lines @@
   V(Word64Equal)                              \
   V(Word64NotEqual)                           \
   V(Word64Or)                                 \
   V(Word64And)                                \
   V(Word64Xor)                                \
   V(Word64Shr)                                \
   V(Word64Sar)                                \
   V(Word64Ror)                                \
   V(UintPtrGreaterThanOrEqual)
 
+enum AllocationFlags : uint8_t {

[Benedikt Meurer, 2016/02/25 13:00:40]

Can you move this into the CodeStubAssembler?

[epertoso, 2016/02/25 13:26:54]

Done.

+  kNone = 0,
+  kTagObject = 1,

[Benedikt Meurer, 2016/02/25 13:00:41]

Don't add kTagObject here. This is terrible in the MacroAssembler (easy to mess
up). Allocate* will always produce tagged pointers.

[epertoso, 2016/02/25 13:26:54]

OK.

+  kDoubleAlignment = 1 << 1,
+  kPretenured = 1 << 2
+};
+
+inline AllocationFlags operator|(AllocationFlags lhs, AllocationFlags rhs) {

[Benedikt Meurer, 2016/02/25 13:00:40]

Use base::Flags and DEFINE_OPERATORS_FOR_FLAGS here.

[epertoso, 2016/02/25 13:26:53]

Done.

+  return static_cast<AllocationFlags>(static_cast<uint8_t>(lhs) |
+                                      static_cast<uint8_t>(rhs));
+}
+
+inline AllocationFlags operator&(AllocationFlags lhs, AllocationFlags rhs) {
+  return static_cast<AllocationFlags>(static_cast<uint8_t>(lhs) &
+                                      static_cast<uint8_t>(rhs));
+}
+
+inline AllocationFlags operator~(AllocationFlags arg) {
+  return static_cast<AllocationFlags>(~static_cast<uint8_t>(arg));
+}
+
 class CodeStubAssembler {
  public:
   // |result_size| specifies the number of results returned by the stub.
   // TODO(rmcilroy): move result_size to the CallInterfaceDescriptor.
   CodeStubAssembler(Isolate* isolate, Zone* zone,
                     const CallInterfaceDescriptor& descriptor,
                     Code::Flags flags, const char* name,
                     size_t result_size = 1);
   virtual ~CodeStubAssembler();
 
@@ skipping 123 matching lines @@
   // Load an object pointer from a buffer that isn't in the heap.
   Node* LoadBufferObject(Node* buffer, int offset);
   // Load a field from an object on the heap.
   Node* LoadObjectField(Node* object, int offset);
 
   // Load an array element from a FixedArray.
   Node* LoadFixedArrayElementSmiIndex(Node* object, Node* smi_index,
                                       int additional_offset = 0);
   Node* LoadFixedArrayElementConstantIndex(Node* object, int index);
 
+  // Allocate in new space.
+  Node* Allocate(int size, AllocationFlags flags);
+
  protected:
   // Protected helpers which delegate to RawMachineAssembler.
   Graph* graph();
   Isolate* isolate();
   Zone* zone();
 
   // Enables subclasses to perform operations before and after a call.
   virtual void CallPrologue();
   virtual void CallEpilogue();
 
  private:
   friend class CodeStubAssemblerTester;
 
   Node* CallN(CallDescriptor* descriptor, Node* code_target, Node** args);
   Node* TailCallN(CallDescriptor* descriptor, Node* code_target, Node** args);
 
   Node* SmiShiftBitsConstant();
 
+  Node* AllocateRawAligned(Node* size_in_bytes, AllocationFlags flags,
+                           Node* top_address, Node* limit_address);
+  Node* AllocateRawUnaligned(Node* size_in_bytes, AllocationFlags flags,
+                             Node* top_adddress, Node* limit_address);
+
   base::SmartPointer<RawMachineAssembler> raw_assembler_;
   Code::Flags flags_;
   const char* name_;
   bool code_generated_;
   ZoneVector<Variable::Impl*> variables_;
 
   DISALLOW_COPY_AND_ASSIGN(CodeStubAssembler);
 };
 
 class CodeStubAssembler::Label {
@@ skipping 21 matching lines @@
   // Map of variables to the list of value nodes that have been added from each
   // merge path in their order of merging.
   std::map<Variable::Impl*, std::vector<Node*>> variable_merges_;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_CODE_STUB_ASSEMBLER_H_