Add Android fonts to blimp engine

Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929
Committed: https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274
Cr-Commit-Position: refs/heads/master@{#379734}

[nyquist, 2016-02-25 00:17:48]

nyquist@chromium.org changed reviewers:
+ dpranke@chromium.org, dtrainor@chromium.org, maniscalco@chromium.org

[nyquist, 2016-02-25 00:17:49]

dpranke: DEPS and GCS integration
maniscalco: blimp/README.md, blimp/docs, blimp/engine, blimp/tools
dtrainor: blimp/fonts

khushalsagar: FYI

[maniscalco, 2016-02-25 00:56:54]

Some quick feedback before I head out.  I'll take another, deeper look tomorrow.

https://codereview.chromium.org/1735783002/diff/1/blimp/README.md
File blimp/README.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/README.md#newcode19
blimp/README.md:19: For updating the fonts that blimp support, read more at
[fonts](docs/fonts.md).
support -> supports

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md
File blimp/docs/fonts.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md#newcode17
blimp/docs/fonts.md:17: $ find ./blimp/fonts -regex '^.*.\(ttf\|otf\)$' -type f
-print0 | \
We usually omit the $ prompt in ```bash``` sections right?

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md#newcode21
blimp/docs/fonts.md:21: If the set of fonts includes more than `.ttf` or `.otf`
files, you must update
What do we wrap our .md's to?  80 cols?  Wrapping in this file looks odd.

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md#newco...
blimp/docs/running.md:98: * `--android-fonts-location=$PATH`: Path to where the
fonts are located.
-location vs -path?  Seems like we use -path elsewhere (e.g.
blimp-client-token-path).  Can we use android-fonts-path?

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
File blimp/engine/engine-manifest.txt (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
blimp/engine/engine-manifest.txt:10: ./libminigbm.so
What's this .so?  Did something change so we now depend on it?

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
File blimp/tools/manifest-blacklist.txt (left):

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
blimp/tools/manifest-blacklist.txt:11: gen/*
I think we used to have deps that pulled in a bunch of gen/ files that we didn't
really need.  Is that no longer the case?

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
blimp/tools/manifest-blacklist.txt:12: mus/mus.mojo
No longer needs to be blacklisted?  Do we no longer have a dep that pulls in
mus/mus.mojo?

[nyquist, 2016-02-25 01:16:40]

https://codereview.chromium.org/1735783002/diff/1/blimp/README.md
File blimp/README.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/README.md#newcode19
blimp/README.md:19: For updating the fonts that blimp support, read more at
[fonts](docs/fonts.md).
On 2016/02/25 00:56:54, maniscalco wrote:
> support -> supports

Done.

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md
File blimp/docs/fonts.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md#newcode17
blimp/docs/fonts.md:17: $ find ./blimp/fonts -regex '^.*.\(ttf\|otf\)$' -type f
-print0 | \
On 2016/02/25 00:56:54, maniscalco wrote:
> We usually omit the $ prompt in ```bash``` sections right?

Doh! My bad. Removed.

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/fonts.md#newcode21
blimp/docs/fonts.md:21: If the set of fonts includes more than `.ttf` or `.otf`
files, you must update
On 2016/02/25 00:56:54, maniscalco wrote:
> What do we wrap our .md's to?  80 cols?  Wrapping in this file looks odd.

Doh! My bad. I had '* ' before, and that took up two less characters.
Fixed.

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md#newco...
blimp/docs/running.md:98: * `--android-fonts-location=$PATH`: Path to where the
fonts are located.
On 2016/02/25 00:56:54, maniscalco wrote:
> -location vs -path?  Seems like we use -path elsewhere (e.g.
> blimp-client-token-path).  Can we use android-fonts-path?

Agreed. I added a comment to the CL that is planning on introducing this switch:
https://codereview.chromium.org/1685053002

With this precedence argument:
$ git grep '\-location\"' -- *switches.cc | wc -l
0
vs
$ git grep '\-path\"' -- *switches.cc | wc -l
10

I'll update this CL if the //content owners agree.

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
File blimp/engine/engine-manifest.txt (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
blimp/engine/engine-manifest.txt:10: ./libminigbm.so
On 2016/02/25 00:56:54, maniscalco wrote:
> What's this .so?  Did something change so we now depend on it?

Apparently. Without it, we fail on launch. I haven't done a bisect yet as to
what added it. This also required me to add LD_LIBRARY_PATH to
//blimp/engine/start_engine.sh.

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
File blimp/tools/manifest-blacklist.txt (left):

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
blimp/tools/manifest-blacklist.txt:11: gen/*
On 2016/02/25 00:56:54, maniscalco wrote:
> I think we used to have deps that pulled in a bunch of gen/ files that we
didn't
> really need.  Is that no longer the case?

They are all caught by the new *mojom.js above.

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
blimp/tools/manifest-blacklist.txt:12: mus/mus.mojo
On 2016/02/25 00:56:54, maniscalco wrote:
> No longer needs to be blacklisted?  Do we no longer have a dep that pulls in
> mus/mus.mojo?

It's caught by *.mojo at the top.

[nyquist, 2016-02-25 01:40:43]

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
File blimp/engine/engine-manifest.txt (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
blimp/engine/engine-manifest.txt:10: ./libminigbm.so
On 2016/02/25 01:16:40, nyquist wrote:
> On 2016/02/25 00:56:54, maniscalco wrote:
> > What's this .so?  Did something change so we now depend on it?
> 
> Apparently. Without it, we fail on launch. I haven't done a bisect yet as to
> what added it. This also required me to add LD_LIBRARY_PATH to
> //blimp/engine/start_engine.sh.

OK, git bisect tells me that this was added in
https://codereview.chromium.org/1716353002

For future reference, this is the list of commands I ran:
$ git checkout cc87033da754d1ec0a34e0dd39798f67fc132085 # my current master
$ git bisect start
$ git bisect bad
$ git checkout 839f0ebff55ebf5e4c7249c0b6aa17aefb8680c7 # some arbitrary old CL
$ git bisect good
$ git bisect run bash -c '[[ "x$(gn desc out-chromeos/Debug
//blimp/engine:blimp_engine runtime_deps | grep libminigbm)" !=
"x./libminigbm.so" ]]'
$ git bisect reset

[David Trainor- moved to gerrit, 2016-02-25 05:26:00]

lgtm thanks tommy!

[maniscalco, 2016-02-25 16:54:05]

LGTM

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md#newco...
blimp/docs/running.md:98: * `--android-fonts-location=$PATH`: Path to where the
fonts are located.
On 2016/02/25 01:16:40, nyquist wrote:
> On 2016/02/25 00:56:54, maniscalco wrote:
> > -location vs -path?  Seems like we use -path elsewhere (e.g.
> > blimp-client-token-path).  Can we use android-fonts-path?
> 
> Agreed. I added a comment to the CL that is planning on introducing this
switch:
> https://codereview.chromium.org/1685053002
> 
> With this precedence argument:
> $ git grep '\-location\"' -- *switches.cc | wc -l
> 0
> vs
> $ git grep '\-path\"' -- *switches.cc | wc -l
> 10
> 
> I'll update this CL if the //content owners agree.

Thanks for following up on this!

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
File blimp/engine/engine-manifest.txt (right):

https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifes...
blimp/engine/engine-manifest.txt:10: ./libminigbm.so
On 2016/02/25 01:40:43, nyquist wrote:
> On 2016/02/25 01:16:40, nyquist wrote:
> > On 2016/02/25 00:56:54, maniscalco wrote:
> > > What's this .so?  Did something change so we now depend on it?
> > 
> > Apparently. Without it, we fail on launch. I haven't done a bisect yet as to
> > what added it. This also required me to add LD_LIBRARY_PATH to
> > //blimp/engine/start_engine.sh.
> 
> OK, git bisect tells me that this was added in
> https://codereview.chromium.org/1716353002
> 
> For future reference, this is the list of commands I ran:
> $ git checkout cc87033da754d1ec0a34e0dd39798f67fc132085 # my current master
> $ git bisect start
> $ git bisect bad
> $ git checkout 839f0ebff55ebf5e4c7249c0b6aa17aefb8680c7 # some arbitrary old
CL
> $ git bisect good
> $ git bisect run bash -c '[[ "x$(gn desc out-chromeos/Debug
> //blimp/engine:blimp_engine runtime_deps | grep libminigbm)" !=
> "x./libminigbm.so" ]]'
> $ git bisect reset

Neat.  Thanks for tracking that down.  I'm not sure there's anything else for us
to do at this point other than add it to the manifest and the ld path (as you've
done in this CL).

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
File blimp/tools/manifest-blacklist.txt (left):

https://codereview.chromium.org/1735783002/diff/1/blimp/tools/manifest-blackl...
blimp/tools/manifest-blacklist.txt:11: gen/*
On 2016/02/25 01:16:40, nyquist wrote:
> On 2016/02/25 00:56:54, maniscalco wrote:
> > I think we used to have deps that pulled in a bunch of gen/ files that we
> didn't
> > really need.  Is that no longer the case?
> 
> They are all caught by the new *mojom.js above.

Ah, right, I forgot how globs work :P

[Dirk Pranke, 2016-02-25 18:22:13]

dpranke@chromium.org changed reviewers:
+ open-source-third-party-reviews@google.com

[Dirk Pranke, 2016-02-25 18:22:15]

This basically lgtm .

Here's a couple of thoughts ...

1) I thought somewhere we had a policy on whether to put all of the git ignore
lines in //.gitignore , but I can't find it now. Most of the lines are there,
but my understanding is that what you've done is better perf-wise, so I think
it's fine to leave it where it is.

More importantly, 

2) I'm not sure if this would be considered "third party code" or not. I've
added open-source-third-party-reviews@ to the R= list, just so they can weigh
in. If so, we might want to move this to //third_party and follow the standard
practice documented at

https://www.chromium.org/developers/adding-3rd-party-libraries

In some sense this stuff might be considered security critical as well, but I
know the security follks are already involved.

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#n...
blimp/docs/running.md:99: Typically this would be
`out-linux/Debug/gen/blimp/fonts`.
Nit: I might not use "android" in the arg name for this ...

[nyquist, 2016-02-25 18:51:27]

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#n...
blimp/docs/running.md:99: Typically this would be
`out-linux/Debug/gen/blimp/fonts`.
On 2016/02/25 18:22:15, Dirk Pranke wrote:
> Nit: I might not use "android" in the arg name for this ...

That part isn't really up to me, but up to the CL that adds the argument:
https://codereview.chromium.org/1685053002/

So, if you look at that CL, it's specifically about forcing a linux build to use
the Android fontmanager instead of the default. I talked to the author of that
CL just now, and he wasn't really sure if it would be good to change it to
something that was not Android-specific.

Feel free to chime in on that CL if you feel otherwise though.

[nyquist, 2016-02-25 18:53:25]

On 2016/02/25 18:22:15, Dirk Pranke wrote:
> This basically lgtm .
> 
> Here's a couple of thoughts ...
> 
> 1) I thought somewhere we had a policy on whether to put all of the git ignore
> lines in //.gitignore , but I can't find it now. Most of the lines are there,
> but my understanding is that what you've done is better perf-wise, so I think
> it's fine to leave it where it is.
> 
> More importantly, 
> 
> 2) I'm not sure if this would be considered "third party code" or not. I've
> added open-source-third-party-reviews@ to the R= list, just so they can weigh
> in. If so, we might want to move this to //third_party and follow the standard
> practice documented at
> 
> https://www.chromium.org/developers/adding-3rd-party-libraries
> 
> In some sense this stuff might be considered security critical as well, but I
> know the security follks are already involved.
> 
> https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md
> File blimp/docs/running.md (right):
> 
>
https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#n...
> blimp/docs/running.md:99: Typically this would be
> `out-linux/Debug/gen/blimp/fonts`.
> Nit: I might not use "android" in the arg name for this ...

Re: using third_party for this: Happy to put it in //third_party/blimp-fonts or
//blimp/third_party/fonts if that is the conclusion.

[Dirk Pranke, 2016-02-25 19:04:33]

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md
File blimp/docs/running.md (right):

https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#n...
blimp/docs/running.md:99: Typically this would be
`out-linux/Debug/gen/blimp/fonts`.
On 2016/02/25 18:51:27, nyquist wrote:
> On 2016/02/25 18:22:15, Dirk Pranke wrote:
> > Nit: I might not use "android" in the arg name for this ...
> 
> That part isn't really up to me, but up to the CL that adds the argument:
> https://codereview.chromium.org/1685053002/
> 
> So, if you look at that CL, it's specifically about forcing a linux build to
use
> the Android fontmanager instead of the default. I talked to the author of that
> CL just now, and he wasn't really sure if it would be good to change it to
> something that was not Android-specific.
> 
> Feel free to chime in on that CL if you feel otherwise though.

It's just a nit, and I don't really have the context to be well informed or care
enough, so I'm fine with things as-is for now :)

[nyquist, 2016-02-26 02:12:06]

Description was changed from

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668
==========

to

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929
==========

[nyquist, 2016-03-07 19:28:46]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 19:29:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735783002/80001

[commit-bot: I haz the power, 2016-03-07 19:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 19:51:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nyquist, 2016-03-07 21:01:16]

open-source-third-party-reviews gave approval out of band.

[nyquist, 2016-03-07 21:04:30]

nyquist@chromium.org changed reviewers:
+ klobag@chromium.org

[nyquist, 2016-03-07 21:04:54]

klobag: PTAL for //third_party OWNERS.

[klobag.chromium, 2016-03-07 22:11:28]

lgtm

[nyquist, 2016-03-07 22:12:46]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-03-07 22:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dtrainor@chromium.org, maniscalco@chromium.org
Link to the patchset: https://codereview.chromium.org/1735783002/#ps100001
(title: "Removed missing file from BUILD.gn")

[commit-bot: I haz the power, 2016-03-07 22:13:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735783002/100001

[commit-bot: I haz the power, 2016-03-07 22:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 22:38:12]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nyquist, 2016-03-07 23:55:47]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-03-07 23:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dtrainor@chromium.org, klobag@chromium.org,
maniscalco@chromium.org
Link to the patchset: https://codereview.chromium.org/1735783002/#ps120001
(title: "Removed deleted file from engine manifest")

[commit-bot: I haz the power, 2016-03-07 23:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735783002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735783002/120001

[commit-bot: I haz the power, 2016-03-08 01:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:21:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-03-08 02:19:10]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2016-03-08 02:19:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735783002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735783002/120001

[commit-bot: I haz the power, 2016-03-08 04:19:54]

Description was changed from

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929
==========

to

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929
==========

[commit-bot: I haz the power, 2016-03-08 04:19:57]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-08 04:20:55]

Description was changed from

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929
==========

to

==========
Add Android fonts to blimp engine

The blimp engine is currently using Linux fonts, which works well
for Linux clients. However, for Android clients, Skia should be
instructed to use Android fonts instead to ensure that the font
rendering works correctly.

This CL adds a starting set of fonts to be used, ensures that they
are part of the engine bundle, and provides documentation for how
to use them in locally hosted engines and also for how to keep the
fonts up to date.

This also updates the engine manifest and starts loading a new
dynamic library while running the engine plus fixes the documentation
for running the engine as a container.

BUG=585668, 588929

Committed: https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274
Cr-Commit-Position: refs/heads/master@{#379734}
==========

[commit-bot: I haz the power, 2016-03-08 04:20:57]

Patchset 7 (id:??) landed as
https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274
Cr-Commit-Position: refs/heads/master@{#379734}

[Nico, 2016-03-08 16:00:30]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-08 16:00:32]

Do we really need that many fonts? `gclient sync` now downloads 205 font files,
which takes quite a while, and I'm almost certain I'm going to use 0 of them.
Are there other approaches?

[nyquist, 2016-03-08 16:05:39]

On 2016/03/08 16:00:32, Nico wrote:
> Do we really need that many fonts? `gclient sync` now downloads 205 font
files,
> which takes quite a while, and I'm almost certain I'm going to use 0 of them.
> Are there other approaches?

We explored other options in this doc:
https://docs.google.com/document/d/1wBiRTTCsnax9gNTm3sXwBU6vER_mqqs5to9WFpVyn...
, but ended up choosing this one.

[nyquist, 2016-03-08 18:14:18]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1772343003/ by nyquist@chromium.org.

The reason for reverting is: Will change to use a single archive instead of
multiple files..

[maniscalco, 2016-03-08 18:15:57]

On 2016/03/08 18:14:18, nyquist wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/1772343003/ by mailto:nyquist@chromium.org.
> 
> The reason for reverting is: Will change to use a single archive instead of
> multiple files..

Good call on reverting.

[hinoka, 2016-03-09 00:00:43]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2016-03-09 00:00:44]

fwiw there's an --extract option that you can use to automatically extract the
archive.

[nyquist, 2016-03-09 00:14:22]

On 2016/03/09 00:00:44, hinoka wrote:
> fwiw there's an --extract option that you can use to automatically extract the
> archive.

Yes, see https://codereview.chromium.org/1776133002/ for the updated CL.