Change //third_party/minigbm to a shared_library

Change //third_party/minigbm to a shared_library

minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.

Committed: https://crrev.com/b04d271f548b30f84c28806fdca654964c4b499e
Cr-Commit-Position: refs/heads/master@{#377143}

[spang, 2016-02-22 23:38:12]

spang@chromium.org changed reviewers:
+ dnicoara@chromium.org

[spang, 2016-02-22 23:38:31]

Description was changed from

==========
Change //third_party/minigbm to a component

minigbm has expoted functions via the PUBLIC #define. These functions
should be exported from libminigbm.so rather than libozone.so. Otherwise,
we'd get multiple definitions if any other target depends on the library.
==========

to

==========
Change //third_party/minigbm to a component

minigbm has exported functions via the PUBLIC #define. These functions
should be exported from libminigbm.so rather than libozone.so. Otherwise,
we'd get multiple definitions if any other target depends on the library.
==========

[spang, 2016-02-23 00:07:19]

Description was changed from

==========
Change //third_party/minigbm to a component

minigbm has exported functions via the PUBLIC #define. These functions
should be exported from libminigbm.so rather than libozone.so. Otherwise,
we'd get multiple definitions if any other target depends on the library.
==========

to

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm.so.1 rather than chrome.
==========

[spang, 2016-02-23 00:07:32]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 00:09:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716353002/20001

[spang, 2016-02-23 01:04:43]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 01:05:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716353002/40001

[spang, 2016-02-23 01:06:06]

Description was changed from

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm.so.1 rather than chrome.
==========

to

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libgbm.so.1 rather than libozone.
==========

[commit-bot: I haz the power, 2016-02-23 01:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 01:46:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dnicoara, 2016-02-23 14:37:41]

lgtm

[spang, 2016-02-23 17:58:51]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:01:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716353002/40001

[commit-bot: I haz the power, 2016-02-23 18:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:53:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[spang, 2016-02-23 21:21:35]

Description was changed from

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libgbm.so.1 rather than libozone.
==========

to

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm.so rather than libozone.
==========

[spang, 2016-02-23 21:21:50]

Description was changed from

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm.so rather than libozone.
==========

to

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.
==========

[spang, 2016-02-23 21:22:33]

The CQ bit was checked by spang@chromium.org

[spang, 2016-02-23 21:22:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/1716353002/#ps60001
(title: "sigh, fix on old buildbots")

[commit-bot: I haz the power, 2016-02-23 21:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716353002/60001

[commit-bot: I haz the power, 2016-02-23 22:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 22:54:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[spang, 2016-02-23 23:09:00]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2016-02-23 23:16:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716353002/60001

[commit-bot: I haz the power, 2016-02-23 23:58:08]

Description was changed from

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.
==========

to

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.
==========

[commit-bot: I haz the power, 2016-02-23 23:58:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-23 23:59:32]

Description was changed from

==========
Change //third_party/minigbm to a shared_library
    
minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.
==========

to

==========
Change //third_party/minigbm to a shared_library

minigbm has exported functions via the PUBLIC #define and is not designed
to be linked statically. These functions should be exported from
libminigbm rather than libozone.

Committed: https://crrev.com/b04d271f548b30f84c28806fdca654964c4b499e
Cr-Commit-Position: refs/heads/master@{#377143}
==========

[commit-bot: I haz the power, 2016-02-23 23:59:33]

Patchset 4 (id:??) landed as
https://crrev.com/b04d271f548b30f84c28806fdca654964c4b499e
Cr-Commit-Position: refs/heads/master@{#377143}