Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1735783002: Add Android fonts to blimp engine (Closed)

Created:
4 years, 10 months ago by nyquist
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, David Trainor- moved to gerrit, hinoka, maniscalco, Nico, klobag.chromium, open-source-third-party-reviews
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, Khushal
Base URL:
https://chromium.googlesource.com/chromium/src.git@khushal-fonts
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Android fonts to blimp engine The blimp engine is currently using Linux fonts, which works well for Linux clients. However, for Android clients, Skia should be instructed to use Android fonts instead to ensure that the font rendering works correctly. This CL adds a starting set of fonts to be used, ensures that they are part of the engine bundle, and provides documentation for how to use them in locally hosted engines and also for how to keep the fonts up to date. This also updates the engine manifest and starts loading a new dynamic library while running the engine plus fixes the documentation for running the engine as a container. BUG=585668, 588929 Committed: https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274 Cr-Commit-Position: refs/heads/master@{#379734}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Addressed initial round of comments from maniscalco@ #

Total comments: 3

Patch Set 3 : Change to --android-fonts-path for command line arg and --quiet for DEPS #

Patch Set 4 : merge origin/master #

Patch Set 5 : Moved to //third_party/blimp_fonts, updated LICENSE-file for OFL fonts, added OWNERS (same as //bliā€¦ #

Patch Set 6 : Removed missing file from BUILD.gn #

Patch Set 7 : Removed deleted file from engine manifest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1551 lines, -13 lines) Patch
M DEPS View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M blimp/README.md View 1 1 chunk +4 lines, -1 line 0 comments Download
M blimp/docs/container.md View 1 4 chunks +4 lines, -4 lines 0 comments Download
A blimp/docs/fonts.md View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
M blimp/docs/running.md View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M blimp/engine/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/Dockerfile View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M blimp/engine/engine-manifest.txt View 1 2 3 4 5 6 2 chunks +207 lines, -2 lines 0 comments Download
M blimp/engine/start_engine.sh View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M blimp/tools/manifest-blacklist.txt View 1 chunk +1 line, -3 lines 0 comments Download
A third_party/blimp_fonts/.gitignore View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/blimp_fonts/AndroidClock.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/AndroidClock_Highlight.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/AndroidClock_Solid.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/BUILD.gn View 1 2 3 4 5 1 chunk +217 lines, -0 lines 0 comments Download
A third_party/blimp_fonts/CarroisGothicSC-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Clockopia.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/ComingSoon.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/CutiveMono.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/DancingScript-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/DancingScript-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/DroidSansFallback.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/DroidSansFallbackFull.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/DroidSansMono.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/LICENSE View 1 2 3 4 1 chunk +230 lines, -0 lines 0 comments Download
A third_party/blimp_fonts/LICENSE.Apache View 1 2 3 4 1 chunk +201 lines, -0 lines 0 comments Download
A + third_party/blimp_fonts/LICENSE.OFL View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/blimp_fonts/MTLc3m.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/MTLmr3m.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NanumGothic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NanumGothicBold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoColorEmoji.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoKufiArabic-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoKufiArabic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoNaskhArabic-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoNaskhArabic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoNaskhArabicUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoNaskhArabicUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSans-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSans-BoldItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSans-Italic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSans-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansArmenian-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansArmenian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansAvestan-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBalinese-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBamum-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBatak-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBengali-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBengali-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBengaliUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBengaliUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBrahmi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBuginese-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansBuhid-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCanadianAboriginal-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCarian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCham-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCham-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCherokee-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCoptic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCuneiform-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansCypriot-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansDeseret-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansDevanagari-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansDevanagari-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansDevanagariUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansDevanagariUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansEgyptianHieroglyphs-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansEthiopic-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansEthiopic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGeorgian-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGeorgian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGlagolitic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGothic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGujarati-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGujarati-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGujaratiUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGujaratiUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGurmukhi-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGurmukhi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGurmukhiUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansGurmukhiUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansHanunoo-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansHebrew-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansHebrew-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansImperialAramaic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansInscriptionalPahlavi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansInscriptionalParthian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansJP-Regular-Subsetted.otf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansJP-Regular.otf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansJavanese-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKR-Regular.otf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKaithi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKannada-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKannada-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKannadaUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKannadaUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKayahLi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKharoshthi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKhmer-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKhmer-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKhmerUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansKhmerUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLao-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLao-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLaoUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLaoUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLepcha-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLimbu-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLinearB-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLisu-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLycian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansLydian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMalayalam-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMalayalam-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMalayalamUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMalayalamUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMandaic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMeeteiMayek-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMongolian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMyanmar-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMyanmar-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMyanmarUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansMyanmarUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansNKo-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansNewTaiLue-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOgham-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOlChiki-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOldItalic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOldPersian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOldSouthArabian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOldTurkic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOriya-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOriya-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOriyaUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOriyaUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansOsmanya-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansPhagsPa-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansPhoenician-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansRejang-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansRunic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSC-Regular.otf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSamaritan-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSaurashtra-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansShavian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSinhala-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSinhala-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSundanese-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSylotiNagri-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSymbols-Regular-Subsetted.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSymbols-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSyriacEastern-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSyriacEstrangela-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansSyriacWestern-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTC-Regular.otf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTagalog-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTagbanwa-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTaiLe-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTaiTham-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTaiViet-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTamil-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTamil-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTamilUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTamilUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTelugu-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTelugu-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTeluguUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTeluguUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThaana-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThaana-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThai-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThai-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThaiUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansThaiUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTibetan-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansTifinagh-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansUI-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansUI-BoldItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansUI-Italic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansUI-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansUgaritic-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansVai-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSansYi-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerif-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerif-BoldItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerif-Italic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerif-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifArmenian-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifArmenian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifGeorgian-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifGeorgian-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifKhmer-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifKhmer-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifLao-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifLao-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifThai-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/NotoSerifThai-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/blimp_fonts/OWNERS View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
A third_party/blimp_fonts/README.chromium View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Black.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-BlackItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-BoldItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Italic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Light.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-LightItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Medium.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-MediumItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-Thin.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/Roboto-ThinItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-Bold.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-BoldItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-Italic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-Light.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-LightItalic.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/RobotoCondensed-Regular.ttf.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/blimp_fonts/fonts.xml View 1 2 3 4 1 chunk +371 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (17 generated)
nyquist
dpranke: DEPS and GCS integration maniscalco: blimp/README.md, blimp/docs, blimp/engine, blimp/tools dtrainor: blimp/fonts khushalsagar: FYI
4 years, 10 months ago (2016-02-25 00:17:49 UTC) #2
maniscalco
Some quick feedback before I head out. I'll take another, deeper look tomorrow. https://codereview.chromium.org/1735783002/diff/1/blimp/README.md File ...
4 years, 10 months ago (2016-02-25 00:56:54 UTC) #3
nyquist
https://codereview.chromium.org/1735783002/diff/1/blimp/README.md File blimp/README.md (right): https://codereview.chromium.org/1735783002/diff/1/blimp/README.md#newcode19 blimp/README.md:19: For updating the fonts that blimp support, read more ...
4 years, 10 months ago (2016-02-25 01:16:40 UTC) #4
nyquist
https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifest.txt File blimp/engine/engine-manifest.txt (right): https://codereview.chromium.org/1735783002/diff/1/blimp/engine/engine-manifest.txt#newcode10 blimp/engine/engine-manifest.txt:10: ./libminigbm.so On 2016/02/25 01:16:40, nyquist wrote: > On 2016/02/25 ...
4 years, 10 months ago (2016-02-25 01:40:43 UTC) #5
David Trainor- moved to gerrit
lgtm thanks tommy!
4 years, 10 months ago (2016-02-25 05:26:00 UTC) #6
maniscalco
LGTM https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/1735783002/diff/1/blimp/docs/running.md#newcode98 blimp/docs/running.md:98: * `--android-fonts-location=$PATH`: Path to where the fonts are ...
4 years, 10 months ago (2016-02-25 16:54:05 UTC) #7
Dirk Pranke
This basically lgtm . Here's a couple of thoughts ... 1) I thought somewhere we ...
4 years, 10 months ago (2016-02-25 18:22:15 UTC) #9
nyquist
https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#newcode99 blimp/docs/running.md:99: Typically this would be `out-linux/Debug/gen/blimp/fonts`. On 2016/02/25 18:22:15, Dirk ...
4 years, 10 months ago (2016-02-25 18:51:27 UTC) #10
nyquist
On 2016/02/25 18:22:15, Dirk Pranke wrote: > This basically lgtm . > > Here's a ...
4 years, 10 months ago (2016-02-25 18:53:25 UTC) #11
Dirk Pranke
https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/1735783002/diff/20001/blimp/docs/running.md#newcode99 blimp/docs/running.md:99: Typically this would be `out-linux/Debug/gen/blimp/fonts`. On 2016/02/25 18:51:27, nyquist ...
4 years, 10 months ago (2016-02-25 19:04:33 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735783002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735783002/80001
4 years, 9 months ago (2016-03-07 19:29:12 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/153757) linux_chromium_rel_ng on ...
4 years, 9 months ago (2016-03-07 19:51:33 UTC) #17
nyquist
open-source-third-party-reviews gave approval out of band.
4 years, 9 months ago (2016-03-07 21:01:16 UTC) #18
nyquist
klobag: PTAL for //third_party OWNERS.
4 years, 9 months ago (2016-03-07 21:04:54 UTC) #20
klobag.chromium
lgtm
4 years, 9 months ago (2016-03-07 22:11:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735783002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735783002/100001
4 years, 9 months ago (2016-03-07 22:13:21 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/60579)
4 years, 9 months ago (2016-03-07 22:38:12 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735783002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735783002/120001
4 years, 9 months ago (2016-03-07 23:56:11 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34630)
4 years, 9 months ago (2016-03-08 01:21:49 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735783002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735783002/120001
4 years, 9 months ago (2016-03-08 02:19:49 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-08 04:19:57 UTC) #35
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/7b1d1d89b247c0bd82d527c6ded5da4128883274 Cr-Commit-Position: refs/heads/master@{#379734}
4 years, 9 months ago (2016-03-08 04:20:57 UTC) #37
Nico
Do we really need that many fonts? `gclient sync` now downloads 205 font files, which ...
4 years, 9 months ago (2016-03-08 16:00:32 UTC) #39
nyquist
On 2016/03/08 16:00:32, Nico wrote: > Do we really need that many fonts? `gclient sync` ...
4 years, 9 months ago (2016-03-08 16:05:39 UTC) #40
nyquist
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1772343003/ by nyquist@chromium.org. ...
4 years, 9 months ago (2016-03-08 18:14:18 UTC) #41
maniscalco
On 2016/03/08 18:14:18, nyquist wrote: > A revert of this CL (patchset #7 id:120001) has ...
4 years, 9 months ago (2016-03-08 18:15:57 UTC) #42
hinoka
fwiw there's an --extract option that you can use to automatically extract the archive.
4 years, 9 months ago (2016-03-09 00:00:44 UTC) #44
nyquist
4 years, 9 months ago (2016-03-09 00:14:22 UTC) #45
Message was sent while issue was closed.
On 2016/03/09 00:00:44, hinoka wrote:
> fwiw there's an --extract option that you can use to automatically extract the
> archive.

Yes, see https://codereview.chromium.org/1776133002/ for the updated CL.

Powered by Google App Engine
This is Rietveld 408576698