Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 1735423002: Revert of Skia Filter Quality and Scaling Metrics (Closed)

Created:
4 years, 10 months ago by ericrk
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Skia Filter Quality and Scaling Metrics (patchset #3 id:60001 of https://codereview.chromium.org/1686203002/ ) Reason for revert: reverting this to address Ilya's comments. Original issue's description: > Skia Filter Quality and Scaling Metrics > > Adds histogram metrics to log the filter quality and scale factor of > each image draw. To make the data easier to consume, this is broken > down into a number of individual histograms: > - Filter quality across all draw calls > - Scale amount across all draw calls > - Scale amount per filter quality (4 histograms total) > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686203002 > > Committed: https://skia.googlesource.com/skia/+/f57b3a6e4a002caf01378832cbd756c6c163a783 TBR=bsalomon@google.com,isherman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/82e26bf23923f20828c850d1a0e01d8bde69cfff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -71 lines) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
ericrk
Created Revert of Skia Filter Quality and Scaling Metrics
4 years, 10 months ago (2016-02-25 22:53:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735423002/1
4 years, 10 months ago (2016-02-25 22:53:13 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-25 22:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735423002/1
4 years, 10 months ago (2016-02-25 23:02:53 UTC) #4
Ilya Sherman
On 2016/02/25 22:53:16, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 10 months ago (2016-02-25 23:25:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735423002/1
4 years, 10 months ago (2016-02-25 23:27:45 UTC) #8
ericrk
On 2016/02/25 23:25:29, Ilya Sherman wrote: > On 2016/02/25 22:53:16, commit-bot: I haz the power ...
4 years, 10 months ago (2016-02-25 23:32:04 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-02-26 04:53:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735423002/1
4 years, 10 months ago (2016-02-26 06:14:44 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-02-26 06:14:46 UTC) #15
fmalita_google_do_not_use
lgtm
4 years, 10 months ago (2016-02-26 06:15:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735423002/1
4 years, 10 months ago (2016-02-26 06:15:23 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/82e26bf23923f20828c850d1a0e01d8bde69cfff
4 years, 10 months ago (2016-02-26 06:15:34 UTC) #20
fmalita_google_do_not_use
4 years, 10 months ago (2016-02-26 06:17:10 UTC) #21
Message was sent while issue was closed.
On 2016/02/26 06:14:46, commit-bot: I haz the power wrote:
> No LGTM from a valid reviewer yet. Please ask for an LGTM from a
> full Skia committer

Hrmph.  Revert not landing without a lgtm!?

FTR, the assert was triggering and blocking the roll - e.g.
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

Powered by Google App Engine
This is Rietveld 408576698