Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/core/SkDevice.cpp

Issue 1735423002: Revert of Skia Filter Quality and Scaling Metrics (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkBitmapDevice.cpp ('k') | src/gpu/SkGpuDevice.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkColorFilter.h" 8 #include "SkColorFilter.h"
9 #include "SkDevice.h" 9 #include "SkDevice.h"
10 #include "SkDraw.h" 10 #include "SkDraw.h"
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 if (kUnknown_SkPixelGeometry == fSurfaceProps.pixelGeometry() 435 if (kUnknown_SkPixelGeometry == fSurfaceProps.pixelGeometry()
436 || this->onShouldDisableLCD(paint)) { 436 || this->onShouldDisableLCD(paint)) {
437 437
438 flags &= ~SkPaint::kLCDRenderText_Flag; 438 flags &= ~SkPaint::kLCDRenderText_Flag;
439 flags |= SkPaint::kGenA8FromLCD_Flag; 439 flags |= SkPaint::kGenA8FromLCD_Flag;
440 } 440 }
441 441
442 return flags; 442 return flags;
443 } 443 }
444 444
445 //////////////////////////////////////////////////////////////////////////////// //////////
446
447 void SkBaseDevice::LogDrawScaleFactor(const SkMatrix& matrix, SkFilterQuality fi lterQuality) {
448 #if SK_HISTOGRAMS_ENABLED
449 enum ScaleFactor {
450 kUpscale_ScaleFactor,
451 kNoScale_ScaleFactor,
452 kDownscale_ScaleFactor,
453 kLargeDownscale_ScaleFactor,
454 };
455
456 SkASSERT(filterQuality != kNone_SkFilterQuality);
457 enum { kScaleFactorCount = kLargeDownscale_ScaleFactor + 1 };
458 float rawScaleFactor = matrix.getMinScale();
459
460 ScaleFactor scaleFactor;
461 if (rawScaleFactor < 0.5f) {
462 scaleFactor = kLargeDownscale_ScaleFactor;
463 } else if (rawScaleFactor < 1.0f) {
464 scaleFactor = kDownscale_ScaleFactor;
465 } else if (rawScaleFactor > 1.0f) {
466 scaleFactor = kUpscale_ScaleFactor;
467 } else {
468 scaleFactor = kNoScale_ScaleFactor;
469 }
470
471 switch (filterQuality) {
472 case kNone_SkFilterQuality:
473 SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.NoneFilterQuality", scaleF actor,
474 kScaleFactorCount);
475 break;
476 case kLow_SkFilterQuality:
477 SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.LowFilterQuality", scaleFa ctor,
478 kScaleFactorCount);
479 break;
480 case kMedium_SkFilterQuality:
481 SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.MediumFilterQuality", scal eFactor,
482 kScaleFactorCount);
483 break;
484 case kHigh_SkFilterQuality:
485 SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.HighFilterQuality", scaleF actor,
486 kScaleFactorCount);
487 break;
488 }
489
490 // Also log filter quality independent scale factor.
491 SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.AnyFilterQuality", scaleFactor, kS caleFactorCount);
492
493 // Also log an overall histogram of filter quality.
494 enum { kFilterQualityCount = kHigh_SkFilterQuality + 1 };
495 SK_HISTOGRAM_ENUMERATION("FilterQuality", filterQuality, kFilterQualityCount );
496 #endif
497 }
498
OLDNEW
« no previous file with comments | « src/core/SkBitmapDevice.cpp ('k') | src/gpu/SkGpuDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698