Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/core/SkDevice.cpp

Issue 1735423002: Revert of Skia Filter Quality and Scaling Metrics (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkBitmapDevice.cpp ('k') | src/gpu/SkGpuDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkDevice.cpp
diff --git a/src/core/SkDevice.cpp b/src/core/SkDevice.cpp
index 4d4470c048e5fa7f872db02cf1f984b8e434630b..78aa3ee52f9bcbd2419cf69db5016b16ae1534c3 100644
--- a/src/core/SkDevice.cpp
+++ b/src/core/SkDevice.cpp
@@ -442,57 +442,3 @@
return flags;
}
-//////////////////////////////////////////////////////////////////////////////////////////
-
-void SkBaseDevice::LogDrawScaleFactor(const SkMatrix& matrix, SkFilterQuality filterQuality) {
-#if SK_HISTOGRAMS_ENABLED
- enum ScaleFactor {
- kUpscale_ScaleFactor,
- kNoScale_ScaleFactor,
- kDownscale_ScaleFactor,
- kLargeDownscale_ScaleFactor,
- };
-
- SkASSERT(filterQuality != kNone_SkFilterQuality);
- enum { kScaleFactorCount = kLargeDownscale_ScaleFactor + 1 };
- float rawScaleFactor = matrix.getMinScale();
-
- ScaleFactor scaleFactor;
- if (rawScaleFactor < 0.5f) {
- scaleFactor = kLargeDownscale_ScaleFactor;
- } else if (rawScaleFactor < 1.0f) {
- scaleFactor = kDownscale_ScaleFactor;
- } else if (rawScaleFactor > 1.0f) {
- scaleFactor = kUpscale_ScaleFactor;
- } else {
- scaleFactor = kNoScale_ScaleFactor;
- }
-
- switch (filterQuality) {
- case kNone_SkFilterQuality:
- SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.NoneFilterQuality", scaleFactor,
- kScaleFactorCount);
- break;
- case kLow_SkFilterQuality:
- SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.LowFilterQuality", scaleFactor,
- kScaleFactorCount);
- break;
- case kMedium_SkFilterQuality:
- SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.MediumFilterQuality", scaleFactor,
- kScaleFactorCount);
- break;
- case kHigh_SkFilterQuality:
- SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.HighFilterQuality", scaleFactor,
- kScaleFactorCount);
- break;
- }
-
- // Also log filter quality independent scale factor.
- SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.AnyFilterQuality", scaleFactor, kScaleFactorCount);
-
- // Also log an overall histogram of filter quality.
- enum { kFilterQualityCount = kHigh_SkFilterQuality + 1 };
- SK_HISTOGRAM_ENUMERATION("FilterQuality", filterQuality, kFilterQualityCount);
-#endif
-}
-
« no previous file with comments | « src/core/SkBitmapDevice.cpp ('k') | src/gpu/SkGpuDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698