Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734083002: GN: Visual Studio generator does not depend on is_debug variable (Closed)

Created:
4 years, 10 months ago by NGG
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Visual Studio generator does not depend on is_debug variable R=brettw@chromium.org, tmoniuszko@opera.com BUG= Committed: https://crrev.com/5e369d0ddbe53298b2d59bd9af3f81ccffa84e0c Cr-Commit-Position: refs/heads/master@{#377699}

Patch Set 1 #

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M tools/gn/visual_studio_writer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 1 5 chunks +9 lines, -16 lines 0 comments Download
M tools/gn/visual_studio_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
NGG
4 years, 10 months ago (2016-02-25 15:56:23 UTC) #1
Tomasz Moniuszko
lgtm
4 years, 10 months ago (2016-02-25 16:11:25 UTC) #2
brettw
lgtm
4 years, 10 months ago (2016-02-25 21:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734083002/20001
4 years, 10 months ago (2016-02-25 22:00:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 23:19:28 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 23:20:42 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5e369d0ddbe53298b2d59bd9af3f81ccffa84e0c
Cr-Commit-Position: refs/heads/master@{#377699}

Powered by Google App Engine
This is Rietveld 408576698