Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1734083002: GN: Visual Studio generator does not depend on is_debug variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index e9f2658e58b26ccbc18ffcb018b0fe4b6824e6a2..6950dd68e2147bd00bfb7e6a14ed42cbd4251978 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -75,7 +75,6 @@ class VisualStudioWriter {
using SolutionFolders = std::vector<SolutionEntry*>;
explicit VisualStudioWriter(const BuildSettings* build_settings,
- bool is_debug_config,
const char* config_platform,
Version version);
~VisualStudioWriter();
@@ -107,9 +106,6 @@ class VisualStudioWriter {
// Visual Studio version string.
const char* version_string_;
- // Indicates if project files are generated for Debug mode configuration.
- bool is_debug_config_;
-
// Platform for solution configuration (Win32, x64). Some projects may be
// configured for different platform.
const char* config_platform_;
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698