Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: tools/gn/visual_studio_writer.h

Issue 1734083002: GN: Visual Studio generator does not depend on is_debug variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_
6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Absolute label dir path. 68 // Absolute label dir path.
69 std::string label_dir_path; 69 std::string label_dir_path;
70 // Configuration platform. May be different than solution config platform. 70 // Configuration platform. May be different than solution config platform.
71 std::string config_platform; 71 std::string config_platform;
72 }; 72 };
73 73
74 using SolutionProjects = std::vector<SolutionProject*>; 74 using SolutionProjects = std::vector<SolutionProject*>;
75 using SolutionFolders = std::vector<SolutionEntry*>; 75 using SolutionFolders = std::vector<SolutionEntry*>;
76 76
77 explicit VisualStudioWriter(const BuildSettings* build_settings, 77 explicit VisualStudioWriter(const BuildSettings* build_settings,
78 bool is_debug_config,
79 const char* config_platform, 78 const char* config_platform,
80 Version version); 79 Version version);
81 ~VisualStudioWriter(); 80 ~VisualStudioWriter();
82 81
83 bool WriteProjectFiles(const Target* target, Err* err); 82 bool WriteProjectFiles(const Target* target, Err* err);
84 bool WriteProjectFileContents(std::ostream& out, 83 bool WriteProjectFileContents(std::ostream& out,
85 const SolutionProject& solution_project, 84 const SolutionProject& solution_project,
86 const Target* target, 85 const Target* target,
87 Err* err); 86 Err* err);
88 void WriteFiltersFileContents(std::ostream& out, const Target* target); 87 void WriteFiltersFileContents(std::ostream& out, const Target* target);
(...skipping 11 matching lines...) Expand all
100 99
101 // Toolset version. 100 // Toolset version.
102 const char* toolset_version_; 101 const char* toolset_version_;
103 102
104 // Project version. 103 // Project version.
105 const char* project_version_; 104 const char* project_version_;
106 105
107 // Visual Studio version string. 106 // Visual Studio version string.
108 const char* version_string_; 107 const char* version_string_;
109 108
110 // Indicates if project files are generated for Debug mode configuration.
111 bool is_debug_config_;
112
113 // Platform for solution configuration (Win32, x64). Some projects may be 109 // Platform for solution configuration (Win32, x64). Some projects may be
114 // configured for different platform. 110 // configured for different platform.
115 const char* config_platform_; 111 const char* config_platform_;
116 112
117 // All projects contained by solution. 113 // All projects contained by solution.
118 SolutionProjects projects_; 114 SolutionProjects projects_;
119 115
120 // Absolute root solution folder path. 116 // Absolute root solution folder path.
121 std::string root_folder_path_; 117 std::string root_folder_path_;
122 118
123 // Folders for all solution projects. 119 // Folders for all solution projects.
124 SolutionFolders folders_; 120 SolutionFolders folders_;
125 121
126 // Semicolon-separated Windows SDK include directories. 122 // Semicolon-separated Windows SDK include directories.
127 std::string windows_kits_include_dirs_; 123 std::string windows_kits_include_dirs_;
128 124
129 // Path formatter for ninja targets. 125 // Path formatter for ninja targets.
130 PathOutput ninja_path_output_; 126 PathOutput ninja_path_output_;
131 127
132 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter); 128 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter);
133 }; 129 };
134 130
135 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 131 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698