Clear recorded slots when creating filler objects.

Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO

Committed: https://crrev.com/c5142d863ba9f7304779f272258902515ead3cb8
Cr-Commit-Position: refs/heads/master@{#34295}

[ulan, 2016-02-25 13:45:07]

ulan@chromium.org changed reviewers:
+ jochen@chromium.org

[ulan, 2016-02-25 13:45:08]

I extracted and generalized the fix from 1735523002, so that we don't miss other
places that can leave recorded slots in freed space.

[ulan, 2016-02-25 13:45:23]

Description was changed from

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
==========

to

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO
==========

[jochen (gone - plz use gerrit), 2016-02-25 13:49:58]

https://codereview.chromium.org/1733333002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1733333002/diff/1/src/heap/heap.h#newcode406
src/heap/heap.h:406: enum RecordedSlotsMode { kClearRecordedSlots,
kNoRecordedSlots };
what about making this an enum class? enum class ClearRecordSlots { kYes, kNo }.
Callsites would be more readable then imo

[ulan, 2016-02-25 14:05:14]

https://codereview.chromium.org/1733333002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1733333002/diff/1/src/heap/heap.h#newcode406
src/heap/heap.h:406: enum RecordedSlotsMode { kClearRecordedSlots,
kNoRecordedSlots };
On 2016/02/25 13:49:57, jochen wrote:
> what about making this an enum class? enum class ClearRecordSlots { kYes, kNo
}.
> Callsites would be more readable then imo

Nice trick! Done.

[jochen (gone - plz use gerrit), 2016-02-25 14:07:56]

lgtm

[ulan, 2016-02-25 14:12:34]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-02-25 14:12:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1733333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1733333002/20001

[commit-bot: I haz the power, 2016-02-25 14:36:20]

Description was changed from

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO
==========

to

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO
==========

[commit-bot: I haz the power, 2016-02-25 14:36:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-25 14:37:27]

Description was changed from

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO
==========

to

==========
Clear recorded slots when creating filler objects.

BUG=chromium:589413
LOG=NO

Committed: https://crrev.com/c5142d863ba9f7304779f272258902515ead3cb8
Cr-Commit-Position: refs/heads/master@{#34295}
==========

[commit-bot: I haz the power, 2016-02-25 14:37:28]

Patchset 2 (id:??) landed as
https://crrev.com/c5142d863ba9f7304779f272258902515ead3cb8
Cr-Commit-Position: refs/heads/master@{#34295}