Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: test/cctest/heap/test-spaces.cc

Issue 1733333002: Clear recorded slots when creating filler objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/heap/test-lab.cc ('k') | test/cctest/heap/utils-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-spaces.cc
diff --git a/test/cctest/heap/test-spaces.cc b/test/cctest/heap/test-spaces.cc
index 41345bc7d16310197ba855e62e41e0430a2be77c..ce04a4c6018f4f52181e8f03bd69f434d0e1470a 100644
--- a/test/cctest/heap/test-spaces.cc
+++ b/test/cctest/heap/test-spaces.cc
@@ -519,7 +519,8 @@ static HeapObject* AllocateUnaligned(NewSpace* space, int size) {
CHECK(!allocation.IsRetry());
HeapObject* filler = NULL;
CHECK(allocation.To(&filler));
- space->heap()->CreateFillerObjectAt(filler->address(), size);
+ space->heap()->CreateFillerObjectAt(filler->address(), size,
+ ClearRecordedSlots::kNo);
return filler;
}
@@ -528,7 +529,8 @@ static HeapObject* AllocateUnaligned(PagedSpace* space, int size) {
CHECK(!allocation.IsRetry());
HeapObject* filler = NULL;
CHECK(allocation.To(&filler));
- space->heap()->CreateFillerObjectAt(filler->address(), size);
+ space->heap()->CreateFillerObjectAt(filler->address(), size,
+ ClearRecordedSlots::kNo);
return filler;
}
« no previous file with comments | « test/cctest/heap/test-lab.cc ('k') | test/cctest/heap/utils-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698