Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 1733333002: Clear recorded slots when creating filler objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-regexp.cc ('k') | test/cctest/heap/test-lab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 88aee8adf89e4794ded2445a3261d83a01ca650f..6a111903010a6244af90e82d1318db07c792c142 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -2068,7 +2068,7 @@ static HeapObject* NewSpaceAllocateAligned(int size,
heap->new_space()->AllocateRawAligned(size, alignment);
HeapObject* obj = NULL;
allocation.To(&obj);
- heap->CreateFillerObjectAt(obj->address(), size);
+ heap->CreateFillerObjectAt(obj->address(), size, ClearRecordedSlots::kNo);
return obj;
}
@@ -2171,7 +2171,7 @@ static HeapObject* OldSpaceAllocateAligned(int size,
heap->old_space()->AllocateRawAligned(size, alignment);
HeapObject* obj = NULL;
allocation.To(&obj);
- heap->CreateFillerObjectAt(obj->address(), size);
+ heap->CreateFillerObjectAt(obj->address(), size, ClearRecordedSlots::kNo);
return obj;
}
@@ -4285,8 +4285,9 @@ TEST(Regress169928) {
AllocationMemento::kSize + kPointerSize);
CHECK(allocation.To(&obj));
Address addr_obj = obj->address();
- CcTest::heap()->CreateFillerObjectAt(
- addr_obj, AllocationMemento::kSize + kPointerSize);
+ CcTest::heap()->CreateFillerObjectAt(addr_obj,
+ AllocationMemento::kSize + kPointerSize,
+ ClearRecordedSlots::kNo);
// Give the array a name, making sure not to allocate strings.
v8::Local<v8::Object> array_obj = v8::Utils::ToLocal(array);
« no previous file with comments | « src/runtime/runtime-regexp.cc ('k') | test/cctest/heap/test-lab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698