third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html - Issue 1730653002: Move squash preventing reasons out of compositing reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html

Issue 1730653002: Move squash preventing reasons out of compositing reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug and test fixes. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-animated-layers.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html

diff --git a/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html b/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html

index 1365ce3a69b5e6b8300a5b388b8031ef21cef749..27bfd320942dfa51fd7f696cd29bfb64bb027c7e 100644

--- a/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html

+++ b/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html

@@ -8,8 +8,9 @@ if (window.testRunner)

testRunner.dumpAsText();

onload = function() {

if (window.internals) {

- var layers = JSON.parse(internals.layerTreeAsText(document, 1));

- assert_true(layers.children[0].children[0].children[1].compositingReasons[1] == "Squashing a layer with blending is not supported.");

+ var layers = JSON.parse(internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_DEBUG_INFO));

+ assert_true(layers.children[0].children[0].children[1].compositingReasons[1] == "Layer was separately composited because it could not be squashed.");

+ assert_true(layers.children[0].children[0].children[1].squashingDisallowedReasons[0] == "Squashing a layer with blending is not supported.");

}

};

-</script>

+</script>