third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h - Issue 1730653002: Move squash preventing reasons out of compositing reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h

Issue 1730653002: Move squash preventing reasons out of compositing reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug and test fixes. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h

index 58eae242fbc16de5166696f2fc24185bdf958e08..a064eb2e831bae1faae254ed74b5f62e35e4746f 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h

@@ -30,6 +30,7 @@

#include "core/layout/compositing/PaintLayerCompositor.h"

#include "platform/geometry/IntRect.h"

#include "platform/geometry/LayoutPoint.h"

+#include "platform/graphics/SquashingDisallowedReasons.h"

#include "wtf/Allocator.h"

namespace blink {

@@ -84,7 +85,7 @@ private:

void assignLayersToBackingsInternal(PaintLayer*, SquashingState&, Vector<PaintLayer*>& layersNeedingPaintInvalidation);

void assignLayersToBackingsForReflectionLayer(PaintLayer* reflectionLayer, Vector<PaintLayer*>& layersNeedingPaintInvalidation);

- CompositingReasons getReasonsPreventingSquashing(const PaintLayer*, const SquashingState&);

+ SquashingDisallowedReasons getReasonsPreventingSquashing(const PaintLayer*, const SquashingState&);

bool squashingWouldExceedSparsityTolerance(const PaintLayer* candidate, const SquashingState&);

void updateSquashingAssignment(PaintLayer*, SquashingState&, CompositingStateTransitionType, Vector<PaintLayer*>& layersNeedingPaintInvalidation);

bool needsOwnBacking(const PaintLayer*) const;