[coverage] Filter some files from instrumentation.

[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}

Committed: https://crrev.com/e55c5c06e2f6cd1d258d4d73e9a3a401a4ee750c
Cr-Commit-Position: refs/heads/master@{#34276}

[Michael Achenbach, 2016-02-23 15:44:59]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

BUG=
==========

to

==========
[coverage] Filter some files from instrumentation.

BUG=chromium:568949
LOG=n
==========

[Michael Achenbach, 2016-02-23 15:44:59]

machenbach@chromium.org changed reviewers:
+ kjellander@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2016-02-23 15:50:19]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

BUG=chromium:568949
LOG=n
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
==========

[Michael Achenbach, 2016-02-23 15:51:01]

PTAL. Tested locally that the files indeed weren't instrumented.

https://codereview.chromium.org/1730543002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1730543002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:365: ['use_goma==1 and ("<(GENERATOR)"=="ninja" or
clang==1)', {
Unfortunately gyp doesn't support clever chaining of wrappers, so I have to
enumerate the cross product of goma and coverage.

[Michael Achenbach, 2016-02-23 15:51:06]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 15:51:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/1

[commit-bot: I haz the power, 2016-02-23 15:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 15:52:26]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/1781)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14177)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/1783)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1779)

[Michael Achenbach, 2016-02-23 15:54:12]

Will fix the goma_dir problem...

[Michael Achenbach, 2016-02-23 15:59:18]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 15:59:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/20001

[tandrii(chromium), 2016-02-23 15:59:57]

lgtm for wrapper, rubber-lgtm for gyp, since i barely get it.

[Michael Achenbach, 2016-02-23 16:01:01]

OK - goma seems fixed with patch 2

[Michael Achenbach, 2016-02-23 16:09:41]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true
==========

[Michael Achenbach, 2016-02-23 16:09:46]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-02-23 16:09:51]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/20001

[commit-bot: I haz the power, 2016-02-23 16:20:35]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true
==========

[commit-bot: I haz the power, 2016-02-23 16:20:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-23 16:21:53]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

[commit-bot: I haz the power, 2016-02-23 16:21:54]

Patchset 2 (id:??) landed as
https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

[Michael Achenbach, 2016-02-23 17:33:34]

Yea - ~20% speed-up thanks to this!
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20gcov%20cov...

We're getting there... :)

[Michael Achenbach, 2016-02-24 11:41:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1727383002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks local make builds..

[Michael Achenbach, 2016-02-24 12:48:54]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

[Michael Achenbach, 2016-02-24 15:45:48]

TBR - fixing regression with make

https://codereview.chromium.org/1730543002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1730543002/diff/40001/build/standalone.gypi#n...
build/standalone.gypi:152: 
Moved this one variable nesting level higher, so that clang is available in the
conditions on the lower level.

[Michael Achenbach, 2016-02-24 15:46:03]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-02-24 15:46:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1730543002/#ps40001
(title: "Fix gyp for make")

[Michael Achenbach, 2016-02-24 15:46:06]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-02-24 15:46:12]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n
NOTRY=true

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

[Michael Achenbach, 2016-02-24 15:46:21]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-02-24 15:46:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/40001

[Michael Achenbach, 2016-02-24 15:46:56]

FYI: ishell, trying to reland with a fix

[commit-bot: I haz the power, 2016-02-24 16:04:09]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

[commit-bot: I haz the power, 2016-02-24 16:04:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-24 16:04:55]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

[commit-bot: I haz the power, 2016-02-24 16:04:57]

Patchset 3 (id:??) landed as
https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

[JF, 2016-02-24 16:59:12]

jfb@chromium.org changed reviewers:
+ jfb@chromium.org

[JF, 2016-02-24 16:59:12]

https://codereview.chromium.org/1730543002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1730543002/diff/40001/build/standalone.gypi#n...
build/standalone.gypi:158: }],
I think this breaks gclient sync:


gyp: name 'v8_target_arch' is not defined while evaluating condition
'(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and 
         (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in
/media/jfb/ssd/v8/v8/build/all.gyp
Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1
in /media/jfb/ssd/v8

[JF, 2016-02-24 17:57:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1737433002/ by jfb@chromium.org.

The reason for reverting is: This breaks `gclient sync` because v8_target_arch
isn't defined.

gyp: name 'v8_target_arch' is not defined while evaluating condition
'(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and 
         (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in
/media/jfb/ssd/v8/v8/build/all.gyp
Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1
in /media/jfb/ssd/v8.

[Michael Achenbach, 2016-02-24 20:01:51]

On 2016/02/24 17:57:22, JF wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1737433002/ by mailto:jfb@chromium.org.
> 
> The reason for reverting is: This breaks `gclient sync` because v8_target_arch
> isn't defined.
> 
> gyp: name 'v8_target_arch' is not defined while evaluating condition
> '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64")
and 
>          (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in
> /media/jfb/ssd/v8/v8/build/all.gyp
> Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status
1
> in /media/jfb/ssd/v8.

I think I soon surrender to gyp. All this was an attempt to make the code look
better, but I think I'll go with my original code duplication, as introducing
intermediate variables requires pushing all dominating variables a nesting level
up.

Sad that the bots don't catch any of this. Do you have GYP_DEFINES set? What's
your OS?

[Michael Achenbach, 2016-02-24 20:02:30]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

[Michael Achenbach, 2016-02-24 20:04:01]

On 2016/02/24 20:01:51, Michael Achenbach wrote:
> On 2016/02/24 17:57:22, JF wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/1737433002/ by mailto:jfb@chromium.org.
> > 
> > The reason for reverting is: This breaks `gclient sync` because
v8_target_arch
> > isn't defined.
> > 
> > gyp: name 'v8_target_arch' is not defined while evaluating condition
> > '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64")
> and 
> >          (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0'
in
> > /media/jfb/ssd/v8/v8/build/all.gyp
> > Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit
status
> 1
> > in /media/jfb/ssd/v8.
> 
> I think I soon surrender to gyp. All this was an attempt to make the code look
> better, but I think I'll go with my original code duplication, as introducing
> intermediate variables requires pushing all dominating variables a nesting
level
> up.
> 
> Sad that the bots don't catch any of this. Do you have GYP_DEFINES set? What's
> your OS?

Never mind. Could repro. The bots don't catch this because they all gclient sync
--nohooks and then call runhooks with v8_target_arch explicitly set.

[Michael Achenbach, 2016-02-24 20:09:22]

PTAL. One more fix in patch 4. v8_target_arch was not available on that nesting
level. Now it is.

[Michael Achenbach, 2016-02-24 20:09:38]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 20:09:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/60001

[commit-bot: I haz the power, 2016-02-24 20:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 20:28:13]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-02-25 07:53:06]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-02-25 07:53:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1730543002/#ps60001
(title: "One more fix.")

[commit-bot: I haz the power, 2016-02-25 07:53:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/60001

[commit-bot: I haz the power, 2016-02-25 07:54:43]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

[commit-bot: I haz the power, 2016-02-25 07:54:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-25 07:55:37]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

[commit-bot: I haz the power, 2016-02-25 07:55:38]

Patchset 4 (id:??) landed as
https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}

[Michael Achenbach, 2016-02-25 08:20:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1733213002/ by machenbach@chromium.org.

The reason for reverting is: Prevents using goma with make..

[Michael Achenbach, 2016-02-25 08:24:40]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

[Michael Achenbach, 2016-02-25 08:48:14]

PTAL at patch 5. This is basically where I started without any code-duplication
improvement attempts, which are too tricky and not worth it given the gn move
ahead.

[Michael Achenbach, 2016-02-25 08:49:30]

On 2016/02/25 08:48:14, Michael Achenbach wrote:
> PTAL at patch 5. This is basically where I started without any
code-duplication
> improvement attempts, which are too tricky and not worth it given the gn move
> ahead.

Tested locally that "gclient sync", make with goma, ninja with goma still work.

[Michael Achenbach, 2016-02-25 08:49:37]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-02-25 08:49:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1730543002/#ps80001
(title: "Surrender")

[commit-bot: I haz the power, 2016-02-25 08:49:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730543002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730543002/80001

[commit-bot: I haz the power, 2016-02-25 09:19:37]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

[commit-bot: I haz the power, 2016-02-25 09:19:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-25 09:21:05]

Description was changed from

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}
==========

to

==========
[coverage] Filter some files from instrumentation.

This filters test and third_party files to get a speed-up
when running tests and when collecting profile data.

BUG=chromium:568949
LOG=n

Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
Cr-Commit-Position: refs/heads/master@{#34216}

Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
Cr-Commit-Position: refs/heads/master@{#34253}

Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a
Cr-Commit-Position: refs/heads/master@{#34272}

Committed: https://crrev.com/e55c5c06e2f6cd1d258d4d73e9a3a401a4ee750c
Cr-Commit-Position: refs/heads/master@{#34276}
==========

[commit-bot: I haz the power, 2016-02-25 09:21:07]

Patchset 5 (id:??) landed as
https://crrev.com/e55c5c06e2f6cd1d258d4d73e9a3a401a4ee750c
Cr-Commit-Position: refs/heads/master@{#34276}