Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1727383002: Revert of [coverage] Filter some files from instrumentation. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [coverage] Filter some files from instrumentation. (patchset #2 id:20001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: [Sheriff] Breaks local make builds. Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > NOTRY=true > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} TBR=tandrii@chromium.org,kjellander@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Committed: https://crrev.com/bacfd2c4eac946940373866820cb38c644662456 Cr-Commit-Position: refs/heads/master@{#34247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -67 lines) Patch
D build/coverage_wrapper.py View 1 chunk +0 lines, -28 lines 0 comments Download
M build/standalone.gypi View 5 chunks +17 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [coverage] Filter some files from instrumentation.
4 years, 10 months ago (2016-02-24 11:41:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727383002/1
4 years, 10 months ago (2016-02-24 11:41:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 11:41:50 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 11:42:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bacfd2c4eac946940373866820cb38c644662456
Cr-Commit-Position: refs/heads/master@{#34247}

Powered by Google App Engine
This is Rietveld 408576698