Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1737433002: Revert of [coverage] Filter some files from instrumentation. (Closed)

Created:
4 years, 10 months ago by JF
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [coverage] Filter some files from instrumentation. (patchset #3 id:40001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: This breaks `gclient sync` because v8_target_arch isn't defined. gyp: name 'v8_target_arch' is not defined while evaluating condition '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in /media/jfb/ssd/v8/v8/build/all.gyp Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1 in /media/jfb/ssd/v8 Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} > > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a > Cr-Commit-Position: refs/heads/master@{#34253} TBR=tandrii@chromium.org,kjellander@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Committed: https://crrev.com/4014f1c74619a09dfdac4b3c3ca8749eacf7ba2e Cr-Commit-Position: refs/heads/master@{#34258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -75 lines) Patch
D build/coverage_wrapper.py View 1 chunk +0 lines, -28 lines 0 comments Download
M build/standalone.gypi View 8 chunks +23 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JF
Created Revert of [coverage] Filter some files from instrumentation.
4 years, 10 months ago (2016-02-24 17:57:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737433002/1
4 years, 10 months ago (2016-02-24 17:57:25 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-24 17:57:27 UTC) #4
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-24 18:00:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737433002/1
4 years, 10 months ago (2016-02-24 18:03:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 18:03:33 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:04:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4014f1c74619a09dfdac4b3c3ca8749eacf7ba2e
Cr-Commit-Position: refs/heads/master@{#34258}

Powered by Google App Engine
This is Rietveld 408576698