Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 1730533002: Remove some usages of BrowserThread::UnsafeGetMessageLoopForThread (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 10 months ago
CC:
anandc+watch-blimp_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, extensions-reviews_chromium.org, jam, jochen+watch_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nyquist+watch-blimp_chromium.org, Peter Beverloo, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some usages of BrowserThread::UnsafeGetMessageLoopForThread No functional changes. BUG=546953 Committed: https://crrev.com/abeb69ff4072a386ac2db06a7be218af4bf53711 Cr-Commit-Position: refs/heads/master@{#377549}

Patch Set 1 #

Patch Set 2 : Blimp fix. #

Patch Set 3 : Extensions fix. #

Patch Set 4 : Reformatted. #

Total comments: 3

Messages

Total messages: 16 (7 generated)
Sami
Adding some owners: derat: extensions/shell/browser/shell_browser_context.cc extensions/shell/browser/shell_url_request_context_getter.cc extensions/shell/browser/shell_url_request_context_getter.h mkwst: content/shell/browser/layout_test/layout_test_browser_context.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.cc content/shell/browser/layout_test/layout_test_url_request_context_getter.h content/shell/browser/shell_browser_context.cc content/shell/browser/shell_url_request_context_getter.cc content/shell/browser/shell_url_request_context_getter.h wez: ...
4 years, 10 months ago (2016-02-24 11:43:06 UTC) #4
Mike West
content/shell LGTM.
4 years, 10 months ago (2016-02-24 13:24:11 UTC) #5
Daniel Erat
lgtm
4 years, 10 months ago (2016-02-24 15:49:02 UTC) #6
Wez
blimp/ LGTM
4 years, 10 months ago (2016-02-24 20:57:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730533002/60001
4 years, 10 months ago (2016-02-25 10:45:09 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-25 10:52:44 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/abeb69ff4072a386ac2db06a7be218af4bf53711 Cr-Commit-Position: refs/heads/master@{#377549}
4 years, 10 months ago (2016-02-25 10:53:48 UTC) #13
Ryan Sleevi
No good cleanup deed goes unpunished 1) Thanks for taking this on! 2) A few ...
4 years, 10 months ago (2016-02-25 20:50:14 UTC) #15
Sami
4 years, 10 months ago (2016-02-26 15:57:11 UTC) #16
Message was sent while issue was closed.
Heh, thanks, follow-up here: https://codereview.chromium.org/1736273002/

Powered by Google App Engine
This is Rietveld 408576698