content/shell/browser/layout_test/layout_test_url_request_context_getter.cc - Issue 1730533002: Remove some usages of BrowserThread::UnsafeGetMessageLoopForThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

Issue 1730533002: Remove some usages of BrowserThread::UnsafeGetMessageLoopForThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reformatted. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_url_request_context_getter.h ('k') | content/shell/browser/shell_browser_context.cc » ('j') | content/shell/browser/shell_url_request_context_getter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

diff --git a/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

index 4674a58720acf2805db321ce31bf9b491ce5e724..22c0f162244186cca864440410ff5212f38e1ba5 100644

--- a/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

+++ b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

@@ -17,15 +17,15 @@ namespace content {

LayoutTestURLRequestContextGetter::LayoutTestURLRequestContextGetter(

bool ignore_certificate_errors,

const base::FilePath& base_path,

- base::MessageLoop* io_loop,

- base::MessageLoop* file_loop,

+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,

+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,

ProtocolHandlerMap* protocol_handlers,

URLRequestInterceptorScopedVector request_interceptors,

net::NetLog* net_log)

: ShellURLRequestContextGetter(ignore_certificate_errors,

base_path,

- io_loop,

- file_loop,

+ io_task_runner,

+ file_task_runner,

Ryan Sleevi 2016/02/25 20:50:14 drive by: you could std::move() these (like line 3

protocol_handlers,

std::move(request_interceptors),

net_log) {