Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2035)

Unified Diff: content/shell/browser/shell_url_request_context_getter.cc

Issue 1730533002: Remove some usages of BrowserThread::UnsafeGetMessageLoopForThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reformatted. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_url_request_context_getter.cc
diff --git a/content/shell/browser/shell_url_request_context_getter.cc b/content/shell/browser/shell_url_request_context_getter.cc
index 08d19e684c6a70d77b7c1c0f310c9f9f8e5e4ff3..02fd3f110d96dfccc578abf591991883002da80f 100644
--- a/content/shell/browser/shell_url_request_context_getter.cc
+++ b/content/shell/browser/shell_url_request_context_getter.cc
@@ -67,15 +67,15 @@ void InstallProtocolHandlers(net::URLRequestJobFactoryImpl* job_factory,
ShellURLRequestContextGetter::ShellURLRequestContextGetter(
bool ignore_certificate_errors,
const base::FilePath& base_path,
- base::MessageLoop* io_loop,
- base::MessageLoop* file_loop,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
ProtocolHandlerMap* protocol_handlers,
URLRequestInterceptorScopedVector request_interceptors,
net::NetLog* net_log)
: ignore_certificate_errors_(ignore_certificate_errors),
base_path_(base_path),
- io_loop_(io_loop),
- file_loop_(file_loop),
+ io_task_runner_(io_task_runner),
+ file_task_runner_(file_task_runner),
Ryan Sleevi 2016/02/25 20:50:14 drive by: std::move() here (like line 80)
net_log_(net_log),
request_interceptors_(std::move(request_interceptors)) {
// Must first be created on the UI thread.
@@ -99,8 +99,8 @@ ShellURLRequestContextGetter::CreateNetworkDelegate() {
scoped_ptr<net::ProxyConfigService>
ShellURLRequestContextGetter::GetProxyConfigService() {
- return net::ProxyService::CreateSystemProxyConfigService(
- io_loop_->task_runner(), file_loop_->task_runner());
+ return net::ProxyService::CreateSystemProxyConfigService(io_task_runner_,
+ file_task_runner_);
}
scoped_ptr<net::ProxyService> ShellURLRequestContextGetter::GetProxyService() {

Powered by Google App Engine
This is Rietveld 408576698