Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1730403006: Basic layout tests for WebUSB. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Basic layout tests for WebUSB. This change relands https://codereview.chromium.org/1734753003/ with additional layout tests that provide basic coverage of all the functions defined by the WebUSB API. The tests are implemented by providing mock implementations of the Mojo services that Blink depends on to provide the WebUSB API, allowing the entire test implementation to be done in Javascript. Discovered a number of bugs in isochronous packet handling while writing these. BUG=492204 Committed: https://crrev.com/d20e8f05588bdcc60a94d91f767a08c9bb44fc92 Cr-Commit-Position: refs/heads/master@{#378578}

Patch Set 1 : #

Patch Set 2 : Fix leak of Mojo service overrides. #

Patch Set 3 : Fix Mojo tests that depend on extra module loading. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+994 lines, -38 lines) Patch
M content/renderer/usb/web_usb_device_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 2 1 chunk +46 lines, -33 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/mock-services.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/resources/fake-devices.js View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 chunk +437 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/usb.html View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/usbDevice.html View 1 chunk +297 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Reilly Grant (use Gerrit)
Please look again.
4 years, 10 months ago (2016-02-26 20:33:44 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-02-29 20:19:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730403006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730403006/40001
4 years, 9 months ago (2016-02-29 21:35:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181573)
4 years, 9 months ago (2016-02-29 23:08:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730403006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730403006/60001
4 years, 9 months ago (2016-03-01 22:11:37 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 9 months ago (2016-03-01 22:20:01 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d20e8f05588bdcc60a94d91f767a08c9bb44fc92 Cr-Commit-Position: refs/heads/master@{#378578}
4 years, 9 months ago (2016-03-01 22:22:33 UTC) #19
Reilly Grant (use Gerrit)
4 years, 9 months ago (2016-03-01 23:26:19 UTC) #20
Message was sent while issue was closed.
These tests are broken on some bots because of missing mojom.js files. A fix to
the infra scripts is out for review: https://codereview.chromium.org/1752143002

Powered by Google App Engine
This is Rietveld 408576698