third_party/WebKit/Source/modules/webusb/USBDevice.cpp - Issue 1730403006: Basic layout tests for WebUSB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Issue 1730403006: Basic layout tests for WebUSB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mojo tests that depend on extra module loading. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/usb/usbDevice.html ('k') | third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

index 5ef0df98fbd75f9d338278363a7714f1887da5a6..94d3fd955d51b2d009a7e847c51745e7811b3829 100644

--- a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

@@ -141,7 +141,7 @@ public:

HeapVector<Member<USBIsochronousInTransferPacket>> packets(webTransferInfo->status.size());

size_t byteOffset = 0;

for (size_t i = 0; i < webTransferInfo->status.size(); ++i) {

- packets.append(USBIsochronousInTransferPacket::create(convertTransferStatus(webTransferInfo->status[i]), DOMDataView::create(buffer, byteOffset, webTransferInfo->bytesTransferred[i])));

+ packets[i] = USBIsochronousInTransferPacket::create(convertTransferStatus(webTransferInfo->status[i]), DOMDataView::create(buffer, byteOffset, webTransferInfo->bytesTransferred[i]));

byteOffset += webTransferInfo->packetLength[i];

}

return USBIsochronousInTransferResult::create(buffer, packets);

@@ -159,7 +159,7 @@ public:

ASSERT(webTransferInfo->status.size() == webTransferInfo->bytesTransferred.size());

HeapVector<Member<USBIsochronousOutTransferPacket>> packets(webTransferInfo->status.size());

for (size_t i = 0; i < webTransferInfo->status.size(); ++i)

- packets.append(USBIsochronousOutTransferPacket::create(convertTransferStatus(webTransferInfo->status[i]), webTransferInfo->bytesTransferred[i]));

+ packets[i] = USBIsochronousOutTransferPacket::create(convertTransferStatus(webTransferInfo->status[i]), webTransferInfo->bytesTransferred[i]);

return USBIsochronousOutTransferResult::create(packets);

}

};