Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1752143002: Add gen/device to the list of paths searched for Mojo bindings. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add gen/device to the list of paths searched for Mojo bindings. Without this LayoutTests depending on Mojo JS bindings fail. Eventually we should probably start scanning the whole gen directory or compute this list via deps. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/zip_build.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Reilly Grant (use Gerrit)
Please take a look. This will fix the WebKit bots.
4 years, 9 months ago (2016-03-01 23:24:58 UTC) #2
Reilly Grant (use Gerrit)
+Dirk for N+1 redundancy.
4 years, 9 months ago (2016-03-02 00:16:42 UTC) #5
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-02 00:23:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752143002/1
4 years, 9 months ago (2016-03-02 00:24:32 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 00:28:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299038

Powered by Google App Engine
This is Rietveld 408576698