third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html - Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback.

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing files Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html ('K') | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

index ef99d222d1980b65735554ad0bf050f59b1b8ed2..4d5512be2f560e6e51bb01b6dc3f763f168c1621 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

@@ -31,10 +31,11 @@ function unexpectedCallback()

finishJSTest();

}

-function expectedTypeError(error)

+function expectedTypeError(reason)

philipj_slow 2016/02/24 08:14:03 I think error was a better name :)

Guido Urdaneta 2016/02/24 12:42:10 Done.

{

- shouldBe(error.name, "TypeError")

- testPassed("expectedTypeError was called.")

+ window.error = reason;

+ shouldBe('error.name', '"TypeError"');

+ testPassed("expectedTypeError was called.");

}

function onIceChange1()

@@ -54,12 +55,12 @@ function testExecutionOrderClosedConnection()

var localPeerConnection = new webkitRTCPeerConnection(null, null);

localPeerConnection.close();

var counter = 0;

- events = [];

+ window.events = [];

Promise.resolve().then(_ => events[counter++] = 1);

var iceCandidate = new RTCIceCandidate({candidate:"nano nano"});

localPeerConnection.addIceCandidate(iceCandidate, unexpectedCallback, (error) => {

window.error = error;

- shouldBe('error', '"The RTCPeerConnection\'s signalingState is \'closed\'."');

+ shouldBe('error.name', '"InvalidStateError"');

philipj_slow 2016/02/24 08:14:03 It wouldn't hurt to check error.message as well, i

Guido Urdaneta 2016/02/24 12:42:09 Done.

events[counter++] = 2;

});

Promise.resolve().then(_ => {