third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html - Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing files Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

index 38258b1a0c1aab202739a0d98d9485db2f783aaa..043be76507c3d2a9d13b733c37980b89b3e64d04 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

@@ -19,8 +19,8 @@ function requestFailed2(reason)

{

testPassed('requestFailed was called.');

- errorReason = reason;

- shouldBe('errorReason', '"TEST_ERROR"');

+ window.error = reason;

+ shouldBe('error.name', '"OperationError"');

philipj_slow 2016/02/24 08:14:03 Also check error.message, or perhaps error.toStrin

Guido Urdaneta 2016/02/24 12:42:09 Done.

shouldNotThrow("pc.createOffer(dummy, dummy);");

shouldNotThrow("pc.createOffer(dummy, dummy, {});");