Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing files Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
index 542a7603c98f3397b498e100ad7247664a35df6d..00a4b706a6e39a7981ca176c538c1c2ec4d68f8a 100644
--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
@@ -36,15 +36,17 @@ function unexpectedCallback()
finishJSTest();
}
-function expectedTypeError(error)
+function expectedTypeError(reason)
{
- window.error = error;
+ window.error = reason;
shouldBe('error.name', '"TypeError"')
testPassed('expectedTypeError was called.')
}
function expectedInvalidSessionDescription(error)
{
+ window.error = reason;
philipj_slow 2016/02/24 08:14:03 Oops, here the local variable is still called erro
Guido Urdaneta 2016/02/24 12:42:10 Done.
+ shouldBe('error.name', '"InvalidStateError"')
testPassed('expectedInvalidSessionDescription was called.')
}
@@ -53,12 +55,12 @@ function testExecutionOrderClosedConnection()
var localPeerConnection = new webkitRTCPeerConnection(null, null);
localPeerConnection.close();
var counter = 0;
- events = [];
+ window.events = [];
Promise.resolve().then(_ => events[counter++] = 1);
var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
- localPeerConnection.setLocalDescription(sessionDescription, unexpectedCallback, (error) => {
- window.error = error;
- shouldBe('error', '"The RTCPeerConnection\'s signalingState is \'closed\'."');
+ localPeerConnection.setLocalDescription(sessionDescription, unexpectedCallback, (reason) => {
philipj_slow 2016/02/24 08:14:03 Just as an FYI, it's OK to omit the parens when th
Guido Urdaneta 2016/02/24 12:42:10 Done.
+ window.error = reason;
+ shouldBe('error.name', '"InvalidStateError"');
events[counter++] = 2;
});
Promise.resolve().then(_ => {

Powered by Google App Engine
This is Rietveld 408576698