Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1729523002: Revert collecting defined elements. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert collecting defined elements. We decided to resynthesize local elements from summaries. This CL rolls back the following CLs: https://codereview.chromium.org/1687573002 https://codereview.chromium.org/1681493005 R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d9bd7f915de27fc28cae771f64b4d52b873009f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -52 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +3 lines, -24 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +0 lines, -19 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-23 17:46:44 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-23 17:51:40 UTC) #2
scheglov
4 years, 10 months ago (2016-02-23 17:55:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9bd7f915de27fc28cae771f64b4d52b873009f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698