Collect defined elements together with used elements.

Collect defined elements together with used elements.

We cannot visit CompilationUnitElement and reach local variables and
functions. So, we need another way to know them while generating hints.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/4a99fe9e187c98ff0565f78c00969ca0e9cca467

[Paul Berry, 2016-02-09 20:34:25]

lgtm assuming issue with visitElement is addressed.

Also, don't forget to re-run
pkg/analyzer/tool/task_dependency_graph/generate.dart

https://codereview.chromium.org/1687573002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1687573002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:12178: visitElement(Element
element) {
Why not simply:

    element.accept(this);

Or better yet, do it at the call site and then you don't need this method at
all.

[Brian Wilkerson, 2016-02-09 20:35:57]

LGTM

https://codereview.chromium.org/1687573002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1687573002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:12178: visitElement(Element
element) {
I was about to make the same comment. After all, one point of a visitor pattern
is to avoid this kind of 'is' test.

[scheglov, 2016-02-09 20:45:04]

Description was changed from

==========
Collect defined elements together with used elements.

We cannot visit CompilationUnitElement and reach local variables and
functions. So, we need another way to know them while generating hints.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Collect defined elements together with used elements.

We cannot visit CompilationUnitElement and reach local variables and
functions. So, we need another way to know them while generating hints.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/4a99fe9e187c98ff0565f78c00969ca0e9cca467
==========

[scheglov, 2016-02-09 20:45:05]

Committed patchset #1 (id:1) manually as
4a99fe9e187c98ff0565f78c00969ca0e9cca467 (presubmit successful).

[Paul Berry, 2016-02-10 16:21:18]

On 2016/02/09 20:45:05, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 4a99fe9e187c98ff0565f78c00969ca0e9cca467 (presubmit successful).

This CL appears to have led to a unit test failure.  Repro with: python
tools/test.py -aia32 --checked -mrelease -t60
pkg/analysis_server/test/completion_test

Sample output:
FAIL: testLibrary009-4 (expected failure 126)
  server error: {event: server.error, params: {isFatal: false, message: Task
failed: GenerateHintsTask for source /project/bin/test.dart, stackTrace:
Unexpected exception while performing GenerateHintsTask for source
/project/bin/test.dart
  #0      AnalysisTask._safelyPerform (package:analyzer/task/model.dart:328:7)
  #1      AnalysisTask.perform (package:analyzer/task/model.dart:218:7)
  #2      AnalysisDriver.performWorkItem
(package:analyzer/src/task/driver.dart:274:10)
  #3      AnalysisDriver.performAnalysisTask
(package:analyzer/src/task/driver.dart:249:9)
  #4      AnalysisContextImpl.performAnalysisTask.<anonymous closure>
(package:analyzer/src/context/context.dart:1122:27)
  #5      _PerformanceTagImpl.makeCurrentWhile
(package:analyzer/src/generated/utilities_general.dart:212:15)
  #6      AnalysisContextImpl.performAnalysisTask
(package:analyzer/src/context/context.dart:1120:50)
  #7      PerformAnalysisOperation.perform
(package:analysis_server/src/operation/operation_analysis.dart:371:37)
  #8      AnalysisServer.performOperation
(package:analysis_server/src/analysis_server.dart:835:17)
  #9      Future.Future.<anonymous closure> (dart:async/future.dart:118)
  #10     _rootRun (dart:async/zone.dart:891)
  #11     _CustomZone.run (dart:async/zone.dart:790)
  #12     _CustomZone.runGuarded (dart:async/zone.dart:696)
  #13     _CustomZone.bindCallback.<anonymous closure>
(dart:async/zone.dart:721)
  #14     _rootRun (dart:async/zone.dart:895)
  #15     _CustomZone.run (dart:async/zone.dart:790)
  #16     _CustomZone.runGuarded (dart:async/zone.dart:696)
  #17     _CustomZone.bindCallback.<anonymous closure>
(dart:async/zone.dart:721)
  #18     Timer._createTimer.<anonymous closure>
(dart:async-patch/timer_patch.dart:16)
  #19     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:385)
  #20     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:414)
  #21     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:148)
  
  Caused by The null object does not have a method 'accept'.
  
  NoSuchMethodError: method not found: 'accept'
  Receiver: null
  Arguments: [Instance of 'UnusedLocalElementsVerifier']
  #0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
  #1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
  #2      GenerateHintsTask.internalPerform
(package:analyzer/src/task/dart.dart:2683:19)
  #3      AnalysisTask._safelyPerform (package:analyzer/task/model.dart:318:9)
  #4      AnalysisTask.perform (package:analyzer/task/model.dart:218:7)
  #5      AnalysisDriver.performWorkItem
(package:analyzer/src/task/driver.dart:274:10)
  #6      AnalysisDriver.performAnalysisTask
(package:analyzer/src/task/driver.dart:249:9)
  #7      AnalysisContextImpl.performAnalysisTask.<anonymous closure>
(package:analyzer/src/context/context.dart:1122:27)
  #8      _PerformanceTagImpl.makeCurrentWhile
(package:analyzer/src/generated/utilities_general.dart:212:15)
  #9      AnalysisContextImpl.performAnalysisTask
(package:analyzer/src/context/context.dart:1120:50)
  #10     PerformAnalysisOperation.perform
(package:analysis_server/src/operation/operation_analysis.dart:371:37)
  #11     AnalysisServer.performOperation
(package:analysis_server/src/analysis_server.dart:835:17)
  #12     Future.Future.<anonymous closure> (dart:async/future.dart:118)
  #13     _rootRun (dart:async/zone.dart:891)
  #14     _CustomZone.run (dart:async/zone.dart:790)
  #15     _CustomZone.runGuarded (dart:async/zone.dart:696)
  #16     _CustomZone.bindCallback.<anonymous closure>
(dart:async/zone.dart:721)
  #17     _rootRun (dart:async/zone.dart:895)
  #18     _CustomZone.run (dart:async/zone.dart:790)
  #19     _CustomZone.runGuarded (dart:async/zone.dart:696)
  #20     _CustomZone.bindCallback.<anonymous closure>
(dart:async/zone.dart:721)
  #21     Timer._createTimer.<anonymous closure>
(dart:async-patch/timer_patch.dart:16)
  #22     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:385)
  #23     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:414)
  #24     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:148)
  
  }}
  package:unittest/src/simple_configuration.dart 128:34                
SimpleConfiguration.onExpectFailure
  package:unittest/src/simple_configuration.dart 24:13                 
_ExpectFailureHandler.fail
  package:unittest/src/matcher/expect.dart 103:18                       fail
  pkg/analysis_server/test/domain_completion_util.dart 113:7           
AbstractCompletionDomainTest.processNotification
  pkg/analysis_server/test/analysis_abstract.dart 210:7                
AbstractAnalysisTest.setUp.<fn>
  dart:async/zone.dart 902                                             
_rootRunUnary
  dart:async/zone.dart 798                                             
_CustomZone.runUnary
  dart:async/zone.dart 704                                             
_CustomZone.runUnaryGuarded
  dart:async/stream_impl.dart 341                                      
_BufferingStreamSubscription._sendData
  dart:async/stream_impl.dart 270                                      
_BufferingStreamSubscription._add
  dart:async/stream_controller.dart 760                                
_StreamController&&_SyncStreamControllerDispatch._sendData
  dart:async/stream_controller.dart 632                                
_StreamController._add
  dart:async/stream_controller.dart 578                                
_StreamController.add
  pkg/analysis_server/test/mocks.dart 225:28                           
MockServerChannel.sendNotification
  package:analysis_server/src/analysis_server.dart 953:13              
AnalysisServer.sendServerErrorNotification
  package:analysis_server/src/analysis_logger.dart 46:12               
AnalysisLogger.logError
  package:analyzer/task/model.dart 222:12                              
AnalysisTask.perform
  package:analyzer/src/task/driver.dart 274:10                         
AnalysisDriver.performWorkItem
  package:analyzer/src/task/driver.dart 249:9                          
AnalysisDriver.performAnalysisTask
  package:analyzer/src/context/context.dart 1122:27                    
AnalysisContextImpl.performAnalysisTask.<fn>
  package:analyzer/src/generated/utilities_general.dart 212:15         
_PerformanceTagImpl.makeCurrentWhile
  package:analyzer/src/context/context.dart 1120:50                    
AnalysisContextImpl.performAnalysisTask
  package:analysis_server/src/operation/operation_analysis.dart 371:37 
PerformAnalysisOperation.perform
  package:analysis_server/src/analysis_server.dart 835:17              
AnalysisServer.performOperation
  dart:async/future.dart 118                                           
Future.Future.<fn>
  dart:async/zone.dart 891                                              _rootRun
  dart:async/zone.dart 790                                             
_CustomZone.run
  dart:async/zone.dart 696                                             
_CustomZone.runGuarded
  dart:async/zone.dart 721                                             
_CustomZone.bindCallback.<fn>
  dart:async/zone.dart 895                                              _rootRun
  dart:async/zone.dart 790                                             
_CustomZone.run
  dart:async/zone.dart 696                                             
_CustomZone.runGuarded
  dart:async/zone.dart 721                                             
_CustomZone.bindCallback.<fn>
  dart:async-patch/timer_patch.dart 16                                 
Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 385                               
_Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                               
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                            
_RawReceivePortImpl._handleMessage

[scheglov, 2016-02-10 16:45:45]

Fix: https://codereview.chromium.org/1681493005