Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1729523002: Revert collecting defined elements. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/tool/task_dependency_graph/tasks.dot » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index 9215145dae8e44e23ab4766f1f23d3376ee616a5..9bf00502d75e456d7f8bfd004906a55939309dcf 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -2267,8 +2267,6 @@ main() {
@reflectiveTest
class GatherUsedLocalElementsTaskTest extends _AbstractDartTaskTest {
- List<Element> definedElements;
- Set<String> definedElementNames;
UsedLocalElements usedElements;
Set<String> usedElementNames;
@@ -2333,7 +2331,6 @@ main() {
}''');
_computeUsedElements(source);
// validate
- expect(definedElementNames, unorderedEquals(['main', 'v1', 'v2']));
expect(usedElementNames, unorderedEquals(['v2']));
}
@@ -2353,30 +2350,14 @@ main(A a, p) {
''');
_computeUsedElements(source);
// validate
- expect(definedElementNames,
- unorderedEquals(['A', '_m1', '_m2', 'main', 'a', 'p']));
expect(usedElementNames, unorderedEquals(['A', 'a', 'p', '_m2']));
expect(usedElements.members, unorderedEquals(['_m2', '_m3']));
}
- test_perform_unresolvedImportWithPrefix() {
- Source source = newSource(
- '/test.dart',
- r'''
-import 'x' as p;
-''');
- _computeUsedElements(source);
- // validate
- expect(definedElementNames, isEmpty);
- expect(usedElementNames, isEmpty);
- }
-
void _computeUsedElements(Source source) {
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
computeResult(target, USED_LOCAL_ELEMENTS,
matcher: isGatherUsedLocalElementsTask);
- definedElements = outputs[DEFINED_ELEMENTS];
- definedElementNames = definedElements.map((e) => e.name).toSet();
usedElements = outputs[USED_LOCAL_ELEMENTS];
usedElementNames = usedElements.elements.map((e) => e.name).toSet();
}
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/tool/task_dependency_graph/tasks.dot » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698