Adding Deprecation Message for <keygen>

Adding Deprecation Message for <keygen>

BUG=588182
Committed: https://crrev.com/1369d7387a6e858a4be98e9dde29d2811fa95e31
Cr-Commit-Position: refs/heads/master@{#377981}

[svaldez, 2016-02-23 15:22:46]

svaldez@chromium.org changed reviewers:
+ jochen@chromium.org

[svaldez, 2016-02-23 15:22:46]

This is adding the missing deprecation message for <keygen> in the Console.
Planning on trying to get it merged into M49.

[jochen (gone - plz use gerrit), 2016-02-23 15:23:30]

https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:346: return "The <keygen>
element is deprecated and will be removed.";
please use the willBeRemoved() method to construct the message

[svaldez, 2016-02-23 15:35:47]

https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:346: return "The <keygen>
element is deprecated and will be removed.";
On 2016/02/23 15:23:30, jochen wrote:
> please use the willBeRemoved() method to construct the message

The removal timeline is still slightly rough, though the hope is to remove in
54/55.

[jochen (gone - plz use gerrit), 2016-02-23 15:37:43]

On 2016/02/23 at 15:35:47, svaldez wrote:
>
https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):
> 
>
https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/Deprecation.cpp:346: return "The <keygen>
element is deprecated and will be removed.";
> On 2016/02/23 15:23:30, jochen wrote:
> > please use the willBeRemoved() method to construct the message
> 
> The removal timeline is still slightly rough, though the hope is to remove in
54/55.

let's go with M54 for now then?

[jochen (gone - plz use gerrit), 2016-02-23 15:38:36]

lgtm

[svaldez, 2016-02-23 15:38:37]

On 2016/02/23 15:37:43, jochen wrote:
> On 2016/02/23 at 15:35:47, svaldez wrote:
> >
>
https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1729483002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/frame/Deprecation.cpp:346: return "The
<keygen>
> element is deprecated and will be removed.";
> > On 2016/02/23 15:23:30, jochen wrote:
> > > please use the willBeRemoved() method to construct the message
> > 
> > The removal timeline is still slightly rough, though the hope is to remove
in
> 54/55.
> 
> let's go with M54 for now then?

Yeah, also created a new chromestatus feature for this.

[svaldez, 2016-02-23 15:38:44]

The CQ bit was checked by svaldez@chromium.org

[jochen (gone - plz use gerrit), 2016-02-23 15:38:59]

https://codereview.chromium.org/1729483002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1729483002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:116: return "M53, around
September 2016";
please add 54 here

[commit-bot: I haz the power, 2016-02-23 15:39:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729483002/20001

[svaldez, 2016-02-23 15:39:15]

The CQ bit was unchecked by svaldez@chromium.org

[svaldez, 2016-02-23 15:41:07]

The CQ bit was checked by svaldez@chromium.org

[svaldez, 2016-02-23 15:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1729483002/#ps40001
(title: "Adding 54 to list of releases.")

[commit-bot: I haz the power, 2016-02-23 15:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729483002/40001

[commit-bot: I haz the power, 2016-02-23 16:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:50:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[svaldez, 2016-02-23 17:23:16]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2016-02-23 17:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729483002/40001

[commit-bot: I haz the power, 2016-02-23 18:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:45:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[svaldez, 2016-02-24 15:18:19]

On 2016/02/23 18:45:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

So a bunch of tests are failing due to the new Deprecation message showing up.
Should I be modifying all those tests, or adding deprecation messages to the
ignore list in testcfg.py?

[jochen (gone - plz use gerrit), 2016-02-25 11:54:19]

no, updating the layout tests expectations is the way to go

[svaldez, 2016-02-26 18:17:29]

The CQ bit was checked by svaldez@chromium.org

[svaldez, 2016-02-26 18:17:30]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1729483002/#ps260001
(title: "Fixed final test.")

[commit-bot: I haz the power, 2016-02-26 18:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729483002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729483002/260001

[commit-bot: I haz the power, 2016-02-26 21:31:46]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-02-26 21:32:59]

Description was changed from

==========
Adding Deprecation Message for <keygen>

BUG=588182
==========

to

==========
Adding Deprecation Message for <keygen>

BUG=588182

Committed: https://crrev.com/1369d7387a6e858a4be98e9dde29d2811fa95e31
Cr-Commit-Position: refs/heads/master@{#377981}
==========

[commit-bot: I haz the power, 2016-02-26 21:33:01]

Patchset 14 (id:??) landed as
https://crrev.com/1369d7387a6e858a4be98e9dde29d2811fa95e31
Cr-Commit-Position: refs/heads/master@{#377981}