Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1729483002: Adding Deprecation Message for <keygen> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing message. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 static const char* milestoneString(int milestone) 106 static const char* milestoneString(int milestone)
107 { 107 {
108 switch (milestone) { 108 switch (milestone) {
109 case 50: 109 case 50:
110 return "M50, around April 2016"; 110 return "M50, around April 2016";
111 case 51: 111 case 51:
112 return "M51, around June 2016"; 112 return "M51, around June 2016";
113 case 52: 113 case 52:
114 return "M52, around August 2016"; 114 return "M52, around August 2016";
115 case 53: 115 case 53:
116 return "M53, around September 2016"; 116 return "M53, around September 2016";
jochen (gone - plz use gerrit) 2016/02/23 15:38:59 please add 54 here
117 } 117 }
118 118
119 ASSERT_NOT_REACHED(); 119 ASSERT_NOT_REACHED();
120 return nullptr; 120 return nullptr;
121 } 121 }
122 122
123 static String replacedBy(const char* feature, const char* replacement) 123 static String replacedBy(const char* feature, const char* replacement)
124 { 124 {
125 return String::format("%s is deprecated. Please use %s instead.", feature, r eplacement); 125 return String::format("%s is deprecated. Please use %s instead.", feature, r eplacement);
126 } 126 }
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 333
334 case UseCounter::SVGZoomEvent: 334 case UseCounter::SVGZoomEvent:
335 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528"); 335 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528");
336 336
337 case UseCounter::BorderImageWithBorderStyleNone: 337 case UseCounter::BorderImageWithBorderStyleNone:
338 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around June 2016. See https://www.chromestatus.com/features/5 542503914668032 for more details."; 338 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around June 2016. See https://www.chromestatus.com/features/5 542503914668032 for more details.";
339 339
340 case UseCounter::WebAnimationHyphenatedProperty: 340 case UseCounter::WebAnimationHyphenatedProperty:
341 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576"); 341 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576");
342 342
343 case UseCounter::HTMLKeygenElement:
344 return willBeRemoved("The <keygen> element", 54, "5716060992962560");
345
343 // Features that aren't deprecated don't have a deprecation message. 346 // Features that aren't deprecated don't have a deprecation message.
344 default: 347 default:
345 return String(); 348 return String();
346 } 349 }
347 } 350 }
348 351
349 } // namespace blink 352 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698