third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 1729483002: Adding Deprecation Message for <keygen>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1729483002: Adding Deprecation Message for <keygen> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed final test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index c1ccde89a37dd83002b542b3477ae877efc0d53f..a3ad08754356dde3ce23a9cb2f9e03201cb1461e 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -117,6 +117,8 @@ static const char* milestoneString(int milestone)

return "M52, around July 2016";

case 53:

return "M53, around September 2016";

+ case 54:

+ return "M54, around October 2016";

}

ASSERT_NOT_REACHED();

@@ -335,6 +337,9 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)

case UseCounter::PresentationConnectionStateChangeEventListener:

return replacedWillBeRemoved("'PresentationConnection.onstateachange'", "'PresentationConnection.on{connect,close,terminate}'", 51, "5662456714100736");

+ case UseCounter::HTMLKeygenElement:

+ return willBeRemoved("The <keygen> element", 54, "5716060992962560");

// Features that aren't deprecated don't have a deprecation message.

default:

return String();