Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1729293002: Revert of Re-land enable gesture events for wheel events on all platforms other that OSX. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_regression_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land enable gesture events for wheel events on all platforms other that OSX. (patchset #1 id:1 of https://codereview.chromium.org/1724783002/ ) Reason for revert: Perf bot still shows a regression with android for some reason that didn't show up in the trybot. Reverting for now; will try to debug. Original issue's description: > Re-land enable gesture events for wheel events on all platforms other that OSX. > > OSX has some remaining bugs to deal with overscroll for gesture events > but enable it everywhere else. > > Original issue was reverted in https://codereview.chromium.org/1723513002 due to regressions https://crbug.com/588691, https://crbug.com/588613 and https://crbug.com/588503 > > The source of the issues were that gesture events were targeted incorrectly and an extra animation occurred. > These were addressed in https://codereview.chromium.org/1720023002/ and https://codereview.chromium.org/1716283002/ > > And the rerun of the android perf trybot with the fixes looked fine in https://codereview.chromium.org/1729433003/ > > BUG=568183 > > Committed: https://crrev.com/7ae596034010a9f58bb9361cb1c3e48f8b297f36 > Cr-Commit-Position: refs/heads/master@{#377083} TBR=tdresser@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568183 Committed: https://crrev.com/0dbdea3721f4035a7945b59ca949acaaa1b48466 Cr-Commit-Position: refs/heads/master@{#377280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/common/input/input_event_utils.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dtapuska
Created Revert of Re-land enable gesture events for wheel events on all platforms other that ...
4 years, 10 months ago (2016-02-24 13:12:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729293002/1
4 years, 10 months ago (2016-02-24 13:13:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 13:14:39 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0dbdea3721f4035a7945b59ca949acaaa1b48466 Cr-Commit-Position: refs/heads/master@{#377280}
4 years, 10 months ago (2016-02-24 13:16:07 UTC) #6
tdresser
4 years, 10 months ago (2016-02-24 13:17:55 UTC) #7
Message was sent while issue was closed.
On 2016/02/24 13:16:07, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0dbdea3721f4035a7945b59ca949acaaa1b48466
> Cr-Commit-Position: refs/heads/master@{#377280}

Darn.

You should be able to get the perf bots to give you a trace before and after the
regression, if you can't repro it locally.

Powered by Google App Engine
This is Rietveld 408576698