[wasm] I added comparison operators to the Int64Lowering.

[wasm] I added comparison operators to the Int64Lowering.

Comparison operators are lowered using to a lexicographic ordering, e.g.
(a,b) <= (c,d) <<>> (a < c) | (a == c) & (b <= d).

R=titzer@chromium.org

Committed: https://crrev.com/fab253109d36397e020f308356ce068f61cfc241
Cr-Commit-Position: refs/heads/master@{#34287}

[titzer, 2016-02-24 17:41:35]

lgtm other than small comments below

https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering.h
File src/compiler/int64-lowering.h (right):

https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.h:42: void
LowerComparisonToLexicographicComparison(Node* node,
This name is pretty long :)

LowerComparison should be enough I think.

https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:515: // kExprI64LeS:
You can drop the comments from the cases.

[ahaas, 2016-02-25 11:56:08]

https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering.h
File src/compiler/int64-lowering.h (right):

https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.h:42: void
LowerComparisonToLexicographicComparison(Node* node,
On 2016/02/24 at 17:41:35, titzer wrote:
> This name is pretty long :)
> 
> LowerComparison should be enough I think.

Done.

https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:515: // kExprI64LeS:
On 2016/02/24 at 17:41:35, titzer wrote:
> You can drop the comments from the cases.

I added these comments to avoid merge conflicts. I will remove them all when I'm
done with the Int64Lowering. Is it okay if I leave the comments before and after
my change and only remove those comments within my changes?

[ahaas, 2016-02-25 12:12:45]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-02-25 12:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1729263002/#ps40001
(title: "git rebase")

[commit-bot: I haz the power, 2016-02-25 12:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729263002/40001

[commit-bot: I haz the power, 2016-02-25 12:14:39]

Committed patchset #3 (id:40001)

[titzer, 2016-02-25 12:15:42]

On 2016/02/25 11:56:08, ahaas wrote:
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering.h
> File src/compiler/int64-lowering.h (right):
> 
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering...
> src/compiler/int64-lowering.h:42: void
> LowerComparisonToLexicographicComparison(Node* node,
> On 2016/02/24 at 17:41:35, titzer wrote:
> > This name is pretty long :)
> > 
> > LowerComparison should be enough I think.
> 
> Done.
> 
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:515: // kExprI64LeS:
> On 2016/02/24 at 17:41:35, titzer wrote:
> > You can drop the comments from the cases.
> 
> I added these comments to avoid merge conflicts. I will remove them all when
I'm
> done with the Int64Lowering. Is it okay if I leave the comments before and
after
> my change and only remove those comments within my changes?

NBD

[commit-bot: I haz the power, 2016-02-25 12:16:02]

Description was changed from

==========
[wasm] I added comparison operators to the Int64Lowering.

Comparison operators are lowered using to a lexicographic ordering, e.g.
(a,b) <= (c,d) <<>> (a < c) | (a == c) & (b <= d).

R=titzer@chromium.org
==========

to

==========
[wasm] I added comparison operators to the Int64Lowering.

Comparison operators are lowered using to a lexicographic ordering, e.g.
(a,b) <= (c,d) <<>> (a < c) | (a == c) & (b <= d).

R=titzer@chromium.org

Committed: https://crrev.com/fab253109d36397e020f308356ce068f61cfc241
Cr-Commit-Position: refs/heads/master@{#34287}
==========

[commit-bot: I haz the power, 2016-02-25 12:16:03]

Patchset 3 (id:??) landed as
https://crrev.com/fab253109d36397e020f308356ce068f61cfc241
Cr-Commit-Position: refs/heads/master@{#34287}

[ahaas, 2016-02-25 12:38:40]

On 2016/02/25 at 12:15:42, titzer wrote:
> On 2016/02/25 11:56:08, ahaas wrote:
> >
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering.h
> > File src/compiler/int64-lowering.h (right):
> > 
> >
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering...
> > src/compiler/int64-lowering.h:42: void
> > LowerComparisonToLexicographicComparison(Node* node,
> > On 2016/02/24 at 17:41:35, titzer wrote:
> > > This name is pretty long :)
> > > 
> > > LowerComparison should be enough I think.
> > 
> > Done.
> > 
> >
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler.cc
> > File src/compiler/wasm-compiler.cc (right):
> > 
> >
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler....
> > src/compiler/wasm-compiler.cc:515: // kExprI64LeS:
> > On 2016/02/24 at 17:41:35, titzer wrote:
> > > You can drop the comments from the cases.
> > 
> > I added these comments to avoid merge conflicts. I will remove them all when
I'm
> > done with the Int64Lowering. Is it okay if I leave the comments before and
after
> > my change and only remove those comments within my changes?
> 
> NBD

What does NBD mean?

[titzer, 2016-02-25 14:56:29]

On 2016/02/25 12:38:40, ahaas wrote:
> On 2016/02/25 at 12:15:42, titzer wrote:
> > On 2016/02/25 11:56:08, ahaas wrote:
> > >
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering.h
> > > File src/compiler/int64-lowering.h (right):
> > > 
> > >
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/int64-lowering...
> > > src/compiler/int64-lowering.h:42: void
> > > LowerComparisonToLexicographicComparison(Node* node,
> > > On 2016/02/24 at 17:41:35, titzer wrote:
> > > > This name is pretty long :)
> > > > 
> > > > LowerComparison should be enough I think.
> > > 
> > > Done.
> > > 
> > >
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler.cc
> > > File src/compiler/wasm-compiler.cc (right):
> > > 
> > >
>
https://codereview.chromium.org/1729263002/diff/1/src/compiler/wasm-compiler....
> > > src/compiler/wasm-compiler.cc:515: // kExprI64LeS:
> > > On 2016/02/24 at 17:41:35, titzer wrote:
> > > > You can drop the comments from the cases.
> > > 
> > > I added these comments to avoid merge conflicts. I will remove them all
when
> I'm
> > > done with the Int64Lowering. Is it okay if I leave the comments before and
> after
> > > my change and only remove those comments within my changes?
> > 
> > NBD
> 
> What does NBD mean?

no big deal.