[wasm] I added comparison operators to the Int64Lowering.

src/compiler/wasm-compiler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/wasm-compiler.h"
 
 #include "src/isolate-inl.h"
 
 #include "src/base/platform/platform.h"
 
@@ skipping 491 matching lines @@
 // kExprI64Xor:
     case wasm::kExprI64Xor:
       op = m->Word64Xor();
       break;
 // kExprI64Shl:
 // kExprI64ShrU:
 // kExprI64ShrS:
 // kExprI64Eq:
 // kExprI64Ne:
 // kExprI64LtS:
-// kExprI64LeS:
-// kExprI64LtU:
-// kExprI64LeU:
-// kExprI64GtS:
-// kExprI64GeS:
-// kExprI64GtU:
-// kExprI64GeU:
+    case wasm::kExprI64LtS:
+      op = m->Int64LessThan();
+      break;
+    // kExprI64LeS:

[titzer, 2016/02/24 17:41:35]

You can drop the comments from the cases.

[ahaas, 2016/02/25 11:56:08]

I added these comments to avoid merge conflicts. I will remove them all when I'm
done with the Int64Lowering. Is it okay if I leave the comments before and after
my change and only remove those comments within my changes?

+    case wasm::kExprI64LeS:
+      op = m->Int64LessThanOrEqual();
+      break;
+    // kExprI64LtU:
+    case wasm::kExprI64LtU:
+      op = m->Uint64LessThan();
+      break;
+    // kExprI64LeU:
+    case wasm::kExprI64LeU:
+      op = m->Uint64LessThanOrEqual();
+      break;
+    // kExprI64GtS:
+    case wasm::kExprI64GtS:
+      op = m->Int64LessThan();
+      std::swap(left, right);
+      break;
+    // kExprI64GeS:
+    case wasm::kExprI64GeS:
+      op = m->Int64LessThanOrEqual();
+      std::swap(left, right);
+      break;
+    // kExprI64GtU:
+    case wasm::kExprI64GtU:
+      op = m->Uint64LessThan();
+      std::swap(left, right);
+      break;
+    // kExprI64GeU:
+    case wasm::kExprI64GeU:
+      op = m->Uint64LessThanOrEqual();
+      std::swap(left, right);
+      break;
 
 // kExprI32ConvertI64:
 // kExprI64SConvertI32:
 // kExprI64UConvertI32:
 
 // kExprF64ReinterpretI64:
 // kExprI64ReinterpretF64:
 
 // kExprI64Clz:
 // kExprI64Ctz:
@@ skipping 64 matching lines @@
       op = m->Word64Shr();
       break;
     case wasm::kExprI64ShrS:
       op = m->Word64Sar();
       break;
     case wasm::kExprI64Eq:
       op = m->Word64Equal();
       break;
     case wasm::kExprI64Ne:
       return Invert(Binop(wasm::kExprI64Eq, left, right));
-    case wasm::kExprI64LtS:
-      op = m->Int64LessThan();
-      break;
-    case wasm::kExprI64LeS:
-      op = m->Int64LessThanOrEqual();
-      break;
-    case wasm::kExprI64LtU:
-      op = m->Uint64LessThan();
-      break;
-    case wasm::kExprI64LeU:
-      op = m->Uint64LessThanOrEqual();
-      break;
-    case wasm::kExprI64GtS:
-      op = m->Int64LessThan();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GeS:
-      op = m->Int64LessThanOrEqual();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GtU:
-      op = m->Uint64LessThan();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GeU:
-      op = m->Uint64LessThanOrEqual();
-      std::swap(left, right);
-      break;
 #endif
 
     case wasm::kExprF32CopySign:
       return BuildF32CopySign(left, right);
     case wasm::kExprF64CopySign:
       return BuildF64CopySign(left, right);
     case wasm::kExprF32Add:
       op = m->Float32Add();
       break;
     case wasm::kExprF32Sub:
@@ skipping 1613 matching lines @@
         module_env->module->GetName(function.name_offset));
   }
 
   return code;
 }
 
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8