Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1729263002: [wasm] I added comparison operators to the Int64Lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/int64-lowering.cc ('k') | test/cctest/wasm/test-run-wasm-64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index d69846ffdbe5a9043af93735790c4d4c50fbb4a0..55874bf414b06f67115588236d9640eaba7168c6 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -514,13 +514,34 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,
case wasm::kExprI64Ne:
return Invert(Binop(wasm::kExprI64Eq, left, right));
// kExprI64LtS:
-// kExprI64LeS:
-// kExprI64LtU:
-// kExprI64LeU:
-// kExprI64GtS:
-// kExprI64GeS:
-// kExprI64GtU:
-// kExprI64GeU:
+ case wasm::kExprI64LtS:
+ op = m->Int64LessThan();
+ break;
+ case wasm::kExprI64LeS:
+ op = m->Int64LessThanOrEqual();
+ break;
+ case wasm::kExprI64LtU:
+ op = m->Uint64LessThan();
+ break;
+ case wasm::kExprI64LeU:
+ op = m->Uint64LessThanOrEqual();
+ break;
+ case wasm::kExprI64GtS:
+ op = m->Int64LessThan();
+ std::swap(left, right);
+ break;
+ case wasm::kExprI64GeS:
+ op = m->Int64LessThanOrEqual();
+ std::swap(left, right);
+ break;
+ case wasm::kExprI64GtU:
+ op = m->Uint64LessThan();
+ std::swap(left, right);
+ break;
+ case wasm::kExprI64GeU:
+ op = m->Uint64LessThanOrEqual();
+ std::swap(left, right);
+ break;
// kExprI32ConvertI64:
// kExprI64SConvertI32:
@@ -600,34 +621,6 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,
case wasm::kExprI64ShrS:
op = m->Word64Sar();
break;
- case wasm::kExprI64LtS:
- op = m->Int64LessThan();
- break;
- case wasm::kExprI64LeS:
- op = m->Int64LessThanOrEqual();
- break;
- case wasm::kExprI64LtU:
- op = m->Uint64LessThan();
- break;
- case wasm::kExprI64LeU:
- op = m->Uint64LessThanOrEqual();
- break;
- case wasm::kExprI64GtS:
- op = m->Int64LessThan();
- std::swap(left, right);
- break;
- case wasm::kExprI64GeS:
- op = m->Int64LessThanOrEqual();
- std::swap(left, right);
- break;
- case wasm::kExprI64GtU:
- op = m->Uint64LessThan();
- std::swap(left, right);
- break;
- case wasm::kExprI64GeU:
- op = m->Uint64LessThanOrEqual();
- std::swap(left, right);
- break;
#endif
case wasm::kExprF32CopySign:
« no previous file with comments | « src/compiler/int64-lowering.cc ('k') | test/cctest/wasm/test-run-wasm-64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698