Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 1728423002: [crankshaft] Remove useless HCallJSFunction instruction. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@remove-dynamic-frame-alignment
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove useless HCallJSFunction instruction. Everything that HCallJSFunction does can be easily done using more general HInvokeFunction, so there's no need to have this dedicated instruction around. Committed: https://crrev.com/9f4c3e748ef84f46ec5d03e9fb3cccbe8b846e57 Cr-Commit-Position: refs/heads/master@{#34320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -588 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 8 chunks +11 lines, -50 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -33 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728423002/1
4 years, 10 months ago (2016-02-24 19:40:49 UTC) #2
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-24 19:48:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 20:03:28 UTC) #6
Benedikt Meurer
Very nice! I love this stuff. LGTM
4 years, 10 months ago (2016-02-25 04:55:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728423002/1
4 years, 10 months ago (2016-02-26 09:50:46 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 10:13:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728423002/1
4 years, 10 months ago (2016-02-26 10:34:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 10:40:28 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 10:41:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f4c3e748ef84f46ec5d03e9fb3cccbe8b846e57
Cr-Commit-Position: refs/heads/master@{#34320}

Powered by Google App Engine
This is Rietveld 408576698