Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1731273003: [crankshaft] [ia32] Remove dynamic frame alignment optimization. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] [ia32] Remove dynamic frame alignment optimization. This optimization does not give us much (see perf try bot results associated with this CL) but complicates things a lot. The main motivation is to avoid additional complexity in tail call optimization. There are some pieces left in the deoptimizer, but I'll address this in a separate CL. Committed: https://crrev.com/fcb83f2015afe63449f7ab070558e0c7f2accb47 Cr-Commit-Position: refs/heads/master@{#34273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -210 lines) Patch
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 7 chunks +16 lines, -147 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M src/ia32/frames-ia32.h View 2 chunks +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731273003/1
4 years, 10 months ago (2016-02-24 19:35:30 UTC) #2
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-24 19:48:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 19:57:20 UTC) #8
Benedikt Meurer
LGTM.
4 years, 10 months ago (2016-02-25 07:30:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731273003/1
4 years, 10 months ago (2016-02-25 08:00:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 08:03:07 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 08:04:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcb83f2015afe63449f7ab070558e0c7f2accb47
Cr-Commit-Position: refs/heads/master@{#34273}

Powered by Google App Engine
This is Rietveld 408576698